Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2e9dfa5

Browse files
committed
Choose ports for test servers less likely to result in conflicts
If we choose ports in the range typically used for ephemeral ports thereis a danger of encountering a port conflict due to a race conditionbetween the time we choose the port in a range below that typically usedto allocate ephemeral ports, but higher than the range typically used bywell known services.Author: Jelte Fenema-Nio, with some editing by me.Discussion:https://postgr.es/m/d6ee8761-39d1-0033-1afb-d5a57ee056f2@gmail.comBackpatch to all live branches (12 and up)
1 parent85242f9 commit2e9dfa5

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

‎src/test/perl/PostgreSQL/Test/Cluster.pm

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,14 @@ our $min_compat = 12;
127127
# list of file reservations made by get_free_port
128128
my@port_reservation_files;
129129

130+
# We want to choose a server port above the range that servers typically use
131+
# on Unix systems and below the range those systems typically use for ephemeral
132+
# client ports.
133+
# That way we minimize the risk of getting a port collision. These two values
134+
# are chosen to reflect that. We will always choose a port in this range.
135+
my$port_lower_bound = 10200;
136+
my$port_upper_bound = 32767;
137+
130138
INIT
131139
{
132140

@@ -151,7 +159,8 @@ INIT
151159
$ENV{PGDATABASE} ='postgres';
152160

153161
# Tracking of last port value assigned to accelerate free port lookup.
154-
$last_port_assigned =int(rand() * 16384) + 49152;
162+
my$num_ports =$port_upper_bound -$port_lower_bound;
163+
$last_port_assigned =int(rand() *$num_ports) +$port_lower_bound;
155164

156165
# Set the port lock directory
157166

@@ -1516,7 +1525,7 @@ sub get_free_port
15161525
{
15171526

15181527
# advance $port, wrapping correctly around range end
1519-
$port =49152if ++$port >= 65536;
1528+
$port =$port_lower_boundif ++$port >$port_upper_bound;
15201529
print"# Checking port$port\n";
15211530

15221531
# Check first that candidate port number is not included in

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp