NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2e21e28

committed

Add missing assign hook for GUC checkpoint_completion_target

This is wrong since88e9823, that has switched the WAL sizingconfiguration from checkpoint_segments to min_wal_size andmax_wal_size. This missed the recalculation of the internal value ofthe internal "CheckPointSegments", that works as a mapping of the oldGUC checkpoint_segments, on reload, for example, and it controls thetiming of checkpoints depending on the volume of WAL generated.Most users tend to leave checkpoint_completion_target at 0.9 to smooththe I/O workload, which is why I guess this has gone unnoticed for solong, still it can be useful to tweak and reload the value dynamicallyin some cases to control the timing of checkpoints.Author: Bharath RupireddyDiscussion:https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.comBackpatch-through: 11

1 parentefd2474 commit2e21e28Copy full SHA for 2e21e28

File tree

1 file changed

-1

lines changed

src/backend/utils/misc
- guc.c

1 file changed

-1

lines changed

`‎src/backend/utils/misc/guc.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3798,7 +3798,7 @@ static struct config_real ConfigureNamesReal[] =`
`3798`	`3798`	`},`
`3799`	`3799`	`&CheckPointCompletionTarget,`
`3800`	`3800`	`0.9,0.0,1.0,`
`3801`		`-NULL,NULL,NULL`
	`3801`	`+NULL,assign_checkpoint_completion_target,NULL`
`3802`	`3802`	`},`
`3803`	`3803`
`3804`	`3804`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2e21e28

File tree

1 file changed

1 file changed

`‎src/backend/utils/misc/guc.c`

0 commit comments