Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2dc4f01

Browse files
committed
In initdb, ensure stdout/stderr buffering behavior is what we expect.
Since this program may print to either stdout or stderr, the relativeordering of its messages depends on the buffering behavior of those files.Force stdout to be line-buffered and stderr to be unbuffered, ensuringthat the behavior will match standard Unix interactive behavior, evenwhen stdout and stderr are rerouted to a file.Per complaint from Tomas Vondra. The particular case he pointed out isnew in HEAD, but issues of the same sort could arise in any branch withother error messages, so back-patch to all branches.I'm unsure whether we might not want to do this in other client programsas well. For the moment, just fix initdb.
1 parent2e6602d commit2dc4f01

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

‎src/bin/initdb/initdb.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3523,6 +3523,15 @@ main(int argc, char *argv[])
35233523
char*effective_user;
35243524
charbin_dir[MAXPGPATH];
35253525

3526+
/*
3527+
* Ensure that buffering behavior of stdout and stderr matches what it is
3528+
* in interactive usage (at least on most platforms). This prevents
3529+
* unexpected output ordering when, eg, output is redirected to a file.
3530+
* POSIX says we must do this before any other usage of these files.
3531+
*/
3532+
setvbuf(stdout,NULL,_IOLBF,0);
3533+
setvbuf(stderr,NULL,_IONBF,0);
3534+
35263535
progname=get_progname(argv[0]);
35273536
set_pglocale_pgservice(argv[0],PG_TEXTDOMAIN("initdb"));
35283537

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp