forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit2d7ead8
committed
pg_stat_statements: Fix test that assumes wal_records = rows.
It's not very robust to assume that each inserted row will produceexactly one WAL record and that no other WAL records will be generatedin the process, because for example a particular transaction couldalways be the one that has to extend clog.Because these tests are not run by 'make installcheck' but only by'make check', it may be that in our current testing infrastructurethis can't be hit, but it doesn't seem like a good idea to rely onthat, since unrelated changes to the regression tests or the waywrite-ahead logging is done could easily cause it to start happening,and debugging such failures is a pain.Adjust the regression test to be less sensitive.Anton Melnikov, reviewed by Julien RouhaudDiscussion:http://postgr.es/m/1ccd00d9-1723-6b68-ae56-655aab00d406@inbox.ru1 parent7b64e4b commit2d7ead8
File tree
2 files changed
+5
-5
lines changed- contrib/pg_stat_statements
- expected
- sql
2 files changed
+5
-5
lines changedLines changed: 4 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
259 | 259 |
| |
260 | 260 |
| |
261 | 261 |
| |
262 |
| - | |
| 262 | + | |
263 | 263 |
| |
264 |
| - | |
| 264 | + | |
265 | 265 |
| |
266 | 266 |
| |
267 |
| - | |
| 267 | + | |
268 | 268 |
| |
269 | 269 |
| |
270 | 270 |
| |
271 | 271 |
| |
272 | 272 |
| |
273 |
| - | |
| 273 | + | |
274 | 274 |
| |
275 | 275 |
| |
276 | 276 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
122 | 122 |
| |
123 | 123 |
| |
124 | 124 |
| |
125 |
| - | |
| 125 | + | |
126 | 126 |
| |
127 | 127 |
| |
128 | 128 |
| |
|
0 commit comments
Comments
(0)