Commit2d6cb17

committed

Remove ill-considered (not to mention undocumented) attempt to make

contrib/intarray's GIN opclass override the built-in default. Per bug #3048and other complaints.

1 parentaa33bdd commit2d6cb17Copy full SHA for 2d6cb17

File tree

-14

lines changed

-14

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,10 @@ This is an implementation of RD-tree data structure using GiST interface`
`2`	`2`	`of PostgreSQL. It has built-in lossy compression.`
`3`	`3`
`4`	`4`	`Current implementation provides index support for one-dimensional array of`
`5`		`-int4's -gist__int_ops, suitable for small and medium size of arrays (usedon`
	`5`	`+integers:gist__int_ops, suitable for small and medium size of arrays (usedby`
`6`	`6`	`default), and gist__intbig_ops for indexing large arrays (we use superimposed`
`7`		`-signature with length of 4096 bits to represent sets).`
	`7`	`+signature with length of 4096 bits to represent sets). There is also a`
	`8`	`+non-default gin__int_ops for GIN indexes on integer arrays.`
`8`	`9`
`9`	`10`	`All work was done by Teodor Sigaev (teodor@stack.net) and Oleg Bartunov`
`10`	`11`	`(oleg@sai.msu.su). See http://www.sai.msu.su/~megera/postgres/gist`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -458,10 +458,6 @@ AS`
`458`	`458`	`STORAGEintbig_gkey;`
`459`	`459`
`460`	`460`	`--GIN`
`461`		`---mark built-in gin's _int4_ops as non default`
`462`		`-update pg_catalog.pg_opclass set opcdefault = 'f'`
`463`		`-where opcmethod = (select oid from pg_catalog.pg_am where amname='gin') and`
`464`		`- opcname = '_int4_ops';`
`465`	`461`
`466`	`462`	`CREATE FUNCTION ginint4_queryextract(internal, internal, int2)`
`467`	`463`	`RETURNS internal`
`@@ -474,7 +470,7 @@ AS 'MODULE_PATHNAME'`
`474`	`470`	`LANGUAGE C;`
`475`	`471`
`476`	`472`	`CREATE OPERATOR CLASS gin__int_ops`
`477`		`-DEFAULTFOR TYPE _int4 USING gin`
	`473`	`+FOR TYPE _int4 USING gin`
`478`	`474`	`AS`
`479`	`475`	`OPERATOR3&&,`
`480`	`476`	`OPERATOR6= (anyarray, anyarray)RECHECK,`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -516,7 +516,7 @@ SELECT count(*) from test__int WHERE a @@ '(20&23)\|(50&68)';`
`516`	`516`	`(1 row)`
`517`	`517`
`518`	`518`	`DROP INDEX text_idx;`
`519`		`-CREATE INDEX text_idx on test__int using gin ( a );`
	`519`	`+CREATE INDEX text_idx on test__int using gin ( agin__int_ops);`
`520`	`520`	`SELECT count(*) from test__int WHERE a && '{23,50}';`
`521`	`521`	`count`
`522`	`522`	`-------`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ SELECT count(*) from test__int WHERE a @> '{20,23}' or a @> '{50,68}';`
`111`	`111`	`SELECTcount(*)from test__intWHERE a @@'(20&23)\|(50&68)';`
`112`	`112`
`113`	`113`	`DROPINDEX text_idx;`
`114`		`-CREATEINDEXtext_idxon test__int using gin ( a );`
	`114`	`+CREATEINDEXtext_idxon test__int using gin ( agin__int_ops);`
`115`	`115`
`116`	`116`	`SELECTcount(*)from test__intWHERE a &&'{23,50}';`
`117`	`117`	`SELECTcount(*)from test__intWHERE a @@'23\|50';`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -123,8 +123,3 @@ DROP FUNCTION boolop(_int4, query_int);`
`123`	`123`	`DROPFUNCTION querytree(query_int);`
`124`	`124`
`125`	`125`	`DROPTYPE query_int CASCADE;`
`126`		`-`
`127`		`---mark built-in gin's _int4_ops as default again`
`128`		`-updatepg_catalog.pg_opclassset opcdefault='t'`
`129`		`-where opcmethod= (selectoidfrompg_catalog.pg_amwhere amname='gin')and`
`130`		`- opcname='_int4_ops';`

Comments

(0)