Commit2d09e44

Amit Kapila

committed

Improve comments for row filtering and toast interaction in logical replication.

Reported-by: Antonin HouskaAuthor: Amit KapilaReviewed-by: Antonin Houska, Ajin CherianDiscussion:https://postgr.es/m/84638.1649152255@antos

1 parent17a856d commit2d09e44Copy full SHA for 2d09e44

File tree

-4

lines changed

-4

lines changed

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1237,10 +1237,11 @@ pgoutput_row_filter(Relation relation, TupleTableSlot *old_slot,`
`1237`	`1237`	`* For inserts, we only have the new tuple.`
`1238`	`1238`	`*`
`1239`	`1239`	`* For updates, we can have only a new tuple when none of the replica`
`1240`		`- * identity columns changed but we still need to evaluate the row filter`
`1241`		`- * for new tuple as the existing values of those columns might not match`
`1242`		`- * the filter. Also, users can use constant expressions in the row filter,`
`1243`		`- * so we anyway need to evaluate it for the new tuple.`
	`1240`	`+ * identity columns changed and none of those columns have external data`
	`1241`	`+ * but we still need to evaluate the row filter for the new tuple as the`
	`1242`	`+ * existing values of those columns might not match the filter. Also, users`
	`1243`	`+ * can use constant expressions in the row filter, so we anyway need to`
	`1244`	`+ * evaluate it for the new tuple.`
`1244`	`1245`	`*`
`1245`	`1246`	`* For deletes, we only have the old tuple.`
`1246`	`1247`	`*/`

Comments

(0)