NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2cfb14e

committed

Fix the off by one errors in ResultSet from 6.5.3, and more.

I'm including a diff ofpostgresql-7.0/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java.I've clearly marked all the fixes I did. Would *someone* who has accessto the cvs please put this in?Joseph Shraibman

1 parenta28f117 commit2cfb14eCopy full SHA for 2cfb14e

File tree

1 file changed

+13

-11

lines changed

src/interfaces/jdbc/org/postgresql/jdbc2
- ResultSet.java

1 file changed

+13

-11

lines changed

`‎src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java`

Lines changed: 13 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -797,12 +797,14 @@ public boolean absolute(int index) throws SQLException`
`797`	`797`
`798`	`798`	`publicvoidafterLast()throwsSQLException`
`799`	`799`	`{`
`800`		`-current_row =rows.size() +1;`
	`800`	`+if (rows.size() >0)`
	`801`	`+current_row =rows.size();`
`801`	`802`	`}`
`802`	`803`
`803`	`804`	`publicvoidbeforeFirst()throwsSQLException`
`804`	`805`	`{`
`805`		`-current_row =0;`
	`806`	`+if (rows.size() >0)`
	`807`	`+current_row = -1;`
`806`	`808`	`}`
`807`	`809`
`808`	`810`	`publicvoidcancelRowUpdates()throwsSQLException`
`@@ -946,7 +948,7 @@ public Ref getRef(int i) throws SQLException`
`946`	`948`
`947`	`949`	`publicintgetRow()throwsSQLException`
`948`	`950`	`{`
`949`		`-returncurrent_row;`
	`951`	`+returncurrent_row +1;`
`950`	`952`	`}`
`951`	`953`
`952`	`954`	`// This one needs some thought, as not all ResultSets come from a statement`
`@@ -967,24 +969,24 @@ public void insertRow() throws SQLException`
`967`	`969`
`968`	`970`	`publicbooleanisAfterLast()throwsSQLException`
`969`	`971`	`{`
`970`		`-throworg.postgresql.Driver.notImplemented();`
	`972`	`+return (current_row >=rows.size() &&rows.size() >0);`
`971`	`973`	`}`
`972`		`-`
	`974`	`+`
`973`	`975`	`publicbooleanisBeforeFirst()throwsSQLException`
`974`	`976`	`{`
`975`		`-throworg.postgresql.Driver.notImplemented();`
	`977`	`+return (current_row <0 &&rows.size() >0);`
`976`	`978`	`}`
`977`		`-`
	`979`	`+`
`978`	`980`	`publicbooleanisFirst()throwsSQLException`
`979`	`981`	`{`
`980`		`-throworg.postgresql.Driver.notImplemented();`
	`982`	`+return (current_row ==0 &&rows.size() >=0);`
`981`	`983`	`}`
`982`		`-`
	`984`	`+`
`983`	`985`	`publicbooleanisLast()throwsSQLException`
`984`	`986`	`{`
`985`		`-throworg.postgresql.Driver.notImplemented();`
	`987`	`+return (current_row ==rows.size() -1 &&rows.size() >0);`
`986`	`988`	`}`
`987`		`-`
	`989`	`+`
`988`	`990`	`publicbooleanlast()throwsSQLException`
`989`	`991`	`{`
`990`	`992`	`if (rows.size() <=0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2cfb14e

File tree

1 file changed

1 file changed

`‎src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java`

0 commit comments