forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit2cf8c7a
committed
Clean up duplicate table and function names in regression tests.
Many of the objects we create during the regression tests are put in thepublic schema, so that using the same names in different regression testscreates a hazard of test failures if any two such scripts run concurrently.This patch cleans up a bunch of latent hazards of that sort, as well as twolive hazards.The current situation in this regard is far worse than it was a year or twoback, because practically all of the partitioning-related test cases havereused table names with enthusiasm. I despaired of cleaning up that messwithin the five most-affected tests (create_table, alter_table, insert,update, inherit); fortunately those don't run concurrently.Other than partitioning problems, most of the issues boil down to usingnames like "foo", "bar", "tmp", etc, without thought for the fact thatother test scripts might use similar names concurrently. I've made aneffort to make all such names more specific.One of the live hazards was that commit7421f4b caused with.sql tocreate a table named "test", conflicting with a similarly-named tablein alter_table.sql; this was exposed in the buildfarm recently.The other one was that join.sql and transactions.sql both create tablesnamed "foo" and "bar"; but join.sql's uses of those names date backonly to December or so.Since commit7421f4b was back-patched to v10, back-patch a minimalfix for that problem. The rest of this is just future-proofing.Discussion:https://postgr.es/m/4627.1521070268@sss.pgh.pa.us1 parent1466bcf commit2cf8c7a
File tree
32 files changed
+2210
-2210
lines changed- src/test/regress
- expected
- sql
32 files changed
+2210
-2210
lines changedLines changed: 228 additions & 228 deletions
Large diffs are not rendered by default.
Lines changed: 8 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
8 | 8 |
| |
9 | 9 |
| |
10 | 10 |
| |
11 |
| - | |
| 11 | + | |
12 | 12 |
| |
13 | 13 |
| |
14 | 14 |
| |
| |||
118 | 118 |
| |
119 | 119 |
| |
120 | 120 |
| |
121 |
| - | |
122 |
| - | |
| 121 | + | |
| 122 | + | |
123 | 123 |
| |
124 | 124 |
| |
125 | 125 |
| |
126 | 126 |
| |
127 |
| - | |
128 |
| - | |
| 127 | + | |
| 128 | + | |
129 | 129 |
| |
130 | 130 |
| |
131 | 131 |
| |
| |||
141 | 141 |
| |
142 | 142 |
| |
143 | 143 |
| |
144 |
| - | |
145 |
| - | |
| 144 | + | |
| 145 | + | |
146 | 146 |
| |
147 | 147 |
| |
148 |
| - | |
| 148 | + | |
149 | 149 |
| |
150 | 150 |
| |
151 | 151 |
| |
|
0 commit comments
Comments
(0)