Commit2cbe3a9

committed

Add CHECK_FOR_INTERRUPTS() to the repeat() function

The repeat() function loops for potentially a long time withoutever checking for interrupts. This prevents, for example, a querycancel from interrupting until the work is all done. Fix byinserting a CHECK_FOR_INTERRUPTS() into the loop.Backpatch to all supported versions.Discussion:https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com

1 parentfa68594 commit2cbe3a9Copy full SHA for 2cbe3a9

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`#include"utils/builtins.h"`
`19`	`19`	`#include"utils/formatting.h"`
`20`	`20`	`#include"mb/pg_wchar.h"`
`21`		`-`
	`21`	`+#include"miscadmin.h"`
`22`	`22`
`23`	`23`	`statictextdotrim(constcharstring,intstringlen,`
`24`	`24`	`constchar*set,intsetlen,`
`@@ -1068,6 +1068,7 @@ repeat(PG_FUNCTION_ARGS)`
`1068`	`1068`	`{`
`1069`	`1069`	`memcpy(cp,sp,slen);`
`1070`	`1070`	`cp+=slen;`
	`1071`	`+CHECK_FOR_INTERRUPTS();`
`1071`	`1072`	`}`
`1072`	`1073`
`1073`	`1074`	`PG_RETURN_TEXT_P(result);`

Comments

(0)