NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2cb1a5a

committed

Fix reading of BitString nodes

The node tokenizer went out of its way to store BitString node valueswithout the leading 'b'. But everything else in the system stores theleading 'b'. This would break if a BitString node isread-printed-read.Also, the node tokenizer didn't know that BitString node tokens couldalso start with 'x'.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us

1 parent43f4b34 commit2cb1a5aCopy full SHA for 2cb1a5a

File tree

1 file changed

-5

lines changed

src/backend/nodes
- read.c

1 file changed

-5

lines changed

`‎src/backend/nodes/read.c`

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ nodeTokenType(const char *token, int length)`
`288`	`288`	`retval=T_Boolean;`
`289`	`289`	`elseif (*token=='"'&&length>1&&token[length-1]=='"')`
`290`	`290`	`retval=T_String;`
`291`		`-elseif (*token=='b')`
	`291`	`+elseif (token=='b'\|\|token=='x')`
`292`	`292`	`retval=T_BitString;`
`293`	`293`	`else`
`294`	`294`	`retval=OTHER_TOKEN;`
`@@ -471,11 +471,10 @@ nodeRead(const char *token, int tok_len)`
`471`	`471`	`break;`
`472`	`472`	`caseT_BitString:`
`473`	`473`	`{`
`474`		`-char*val=palloc(tok_len);`
	`474`	`+char*val=palloc(tok_len+1);`
`475`	`475`
`476`		`-/* skip leading 'b' */`
`477`		`-memcpy(val,token+1,tok_len-1);`
`478`		`-val[tok_len-1]='\0';`
	`476`	`+memcpy(val,token,tok_len);`
	`477`	`+val[tok_len]='\0';`
`479`	`478`	`result= (Node*)makeBitString(val);`
`480`	`479`	`break;`
`481`	`480`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2cb1a5a

File tree

1 file changed

1 file changed

`‎src/backend/nodes/read.c`

0 commit comments