Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2bd49b4

Browse files
committed
Don't Insert() a VFD entry until it's fully built.
Otherwise, if FDDEBUG is enabled, the debugging output fails becauseit tries to read the fileName, which isn't set up yet (and should infact always be NULL).AFAICT, this has been wrong since Berkeley. Before96bf88d,it would accidentally fail to crash on platforms where snprintf()is forgiving about being passed a NULL pointer for %s; but thefile name intended to be included in the debug output wouldn'tever have shown up.Report and fix by Greg Nancarrow. Although this is only visiblybroken in custom-made builds, it still seems worth back-patchingto all supported branches, as the FDDEBUG code is pretty uselessas it stands.Discussion:https://postgr.es/m/CAJcOf-cUDgm9qYtC_B6XrC6MktMPNRby2p61EtSGZKnfotMArw@mail.gmail.com
1 parentcd9c1b3 commit2bd49b4

File tree

1 file changed

+2
-2
lines changed
  • src/backend/storage/file

1 file changed

+2
-2
lines changed

‎src/backend/storage/file/fd.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1486,8 +1486,6 @@ PathNameOpenFilePerm(const char *fileName, int fileFlags, mode_t fileMode)
14861486
DO_DB(elog(LOG,"PathNameOpenFile: success %d",
14871487
vfdP->fd));
14881488

1489-
Insert(file);
1490-
14911489
vfdP->fileName=fnamecopy;
14921490
/* Saved flags are adjusted to be OK for re-opening file */
14931491
vfdP->fileFlags=fileFlags& ~(O_CREAT |O_TRUNC |O_EXCL);
@@ -1496,6 +1494,8 @@ PathNameOpenFilePerm(const char *fileName, int fileFlags, mode_t fileMode)
14961494
vfdP->fdstate=0x0;
14971495
vfdP->resowner=NULL;
14981496

1497+
Insert(file);
1498+
14991499
returnfile;
15001500
}
15011501

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp