NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2b74022

committed

Fix EXEC BACKEND + Windows builds for group privs

Under EXEC BACKEND we also need to be going through the group privilegessetup since we do support that on Unixy systems, so add that toSubPostmasterMain().Under Windows, we need to simply return true fromGetDataDirectoryCreatePerm(), but that wasn't happening due to a missing #else clause.Per buildfarm.

1 parentc37b3d0 commit2b74022Copy full SHA for 2b74022

File tree

2 files changed

+15

-2

lines changed

src
- backend/postmaster
  - postmaster.c
- common
  - file_perm.c

2 files changed

+15

-2

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4801,6 +4801,14 @@ SubPostmasterMain(int argc, char *argv[])`
`4801`	`4801`	`/* Read in remaining GUC variables */`
`4802`	`4802`	`read_nondefault_variables();`
`4803`	`4803`
	`4804`	`+/*`
	`4805`	`+ * Check that the data directory looks valid, which will also check the`
	`4806`	`+ * privileges on the data directory and update our umask and file/group`
	`4807`	`+ * variables for creating files later. Note: this should really be done`
	`4808`	`+ * before we create any files or directories.`
	`4809`	`+ */`
	`4810`	`+checkDataDir();`
	`4811`	`+`
`4804`	`4812`	`/*`
`4805`	`4813`	`* (re-)read control file, as it contains config. The postmaster will`
`4806`	`4814`	`* already have read this, but this process doesn't know about that.`

`‎src/common/file_perm.c`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,14 @@ GetDataDirectoryCreatePerm(const char *dataDir)`
`78`	`78`
`79`	`79`	`/* Set permissions */`
`80`	`80`	`SetDataDirectoryCreatePerm(statBuf.st_mode);`
`81`		`-`
`82`	`81`	`return true;`
`83`		`-#endif/* !defined(WIN32) && !defined(__CYGWIN__) */`
	`82`	`+#else/* !defined(WIN32) && !defined(__CYGWIN__) */`
	`83`	`+/*`
	`84`	`+ * On Windows, we don't have anything to do here since they don't have`
	`85`	`+ * Unix-y permissions.`
	`86`	`+ */`
	`87`	`+return true;`
	`88`	`+#endif`
`84`	`89`	`}`
`85`	`90`
`86`	`91`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2b74022

File tree

2 files changed

2 files changed

`‎src/backend/postmaster/postmaster.c`

`‎src/common/file_perm.c`

0 commit comments