NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2b16208

committed

Fix ILIST_DEBUG build

Inc8ad4d8 dlist_member_check()'s arguments were made const. Unfortunatelythe implementation of dlist_member_check() used dlist_foreach(), whichcurrently doesn't work for const lists.As a workaround, open-code the list iteration. The other check functionsalready do so.Discussion:https://postgr.es/m/20230118182214.co7dp4oahiunwg57@awork3.anarazel.de

1 parent47bb9db commit2b16208Copy full SHA for 2b16208

File tree

1 file changed

-3

lines changed

src/backend/lib
- ilist.c

1 file changed

-3

lines changed

`‎src/backend/lib/ilist.c`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,11 +59,12 @@ slist_delete(slist_head head, const slist_node node)`
`59`	`59`	`void`
`60`	`60`	`dlist_member_check(constdlist_headhead,constdlist_nodenode)`
`61`	`61`	`{`
`62`		`-dlist_iteriter;`
	`62`	`+constdlist_node*cur;`
`63`	`63`
`64`		`-dlist_foreach(iter,head)`
	`64`	`+/* iteration open-coded to due to the use of const */`
	`65`	`+for (cur=head->head.next;cur!=&head->head;cur=cur->next)`
`65`	`66`	`{`
`66`		`-if (iter.cur==node)`
	`67`	`+if (cur==node)`
`67`	`68`	`return;`
`68`	`69`	`}`
`69`	`70`	`elog(ERROR,"double linked list member check failure");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2b16208

File tree

1 file changed

1 file changed

`‎src/backend/lib/ilist.c`

0 commit comments