Commit2b04dfc

committed

Improve error reporting for unsupported effective_io_concurrency setting.

Give a specific error complaining about lack of posix_fadvise() whensomeone tries to set effective_io_concurrency > 0 on platformswithout that.This probably isn't worth extensive back-patching, but I (tgl) feltcramming it into v11 was reasonable.James RobinsonDiscussion:https://postgr.es/m/153771876450.14994.560017943128223619@wrigleys.postgresql.orgDiscussion:https://postgr.es/m/A3942987-5BC7-4F05-B54D-2A0EC2914B33@jlr-photo.com

1 parent61f14cc commit2b04dfcCopy full SHA for 2b04dfc

File tree

+11

-3

lines changed

+11

-3

lines changed

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2649,10 +2649,11 @@ static struct config_int ConfigureNamesInt[] =`
`2649`	`2649`	`},`
`2650`	`2650`	`&effective_io_concurrency,`
`2651`	`2651`	`#ifdefUSE_PREFETCH`
`2652`		`-1,0,MAX_IO_CONCURRENCY,`
	`2652`	`+1,`
`2653`	`2653`	`#else`
`2654`		`-0,0,0,`
	`2654`	`+0,`
`2655`	`2655`	`#endif`
	`2656`	`+0,MAX_IO_CONCURRENCY,`
`2656`	`2657`	`check_effective_io_concurrency,assign_effective_io_concurrency,NULL`
`2657`	`2658`	`},`
`2658`	`2659`
`@@ -10709,6 +10710,11 @@ check_effective_io_concurrency(int newval, void *extra, GucSource source)`
`10709`	`10710`	`else`
`10710`	`10711`	`return false;`
`10711`	`10712`	`#else`
	`10713`	`+if (*newval!=0)`
	`10714`	`+{`
	`10715`	`+GUC_check_errdetail("effective_io_concurrency must be set to 0 on platforms that lack posix_fadvise()");`
	`10716`	`+return false;`
	`10717`	`+}`
`10712`	`10718`	`return true;`
`10713`	`10719`	`#endif/* USE_PREFETCH */`
`10714`	`10720`	`}`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,9 @@`
`136`	`136`	`/*`
`137`	`137`	`* USE_PREFETCH code should be compiled only if we have a way to implement`
`138`	`138`	`* prefetching. (This is decoupled from USE_POSIX_FADVISE because there`
`139`		`- * might in future be support for alternative low-level prefetch APIs.)`
	`139`	`+ * might in future be support for alternative low-level prefetch APIs.`
	`140`	`+ * If you change this, you probably need to adjust the error message in`
	`141`	`+ * check_effective_io_concurrency.)`
`140`	`142`	`*/`
`141`	`143`	`#ifdefUSE_POSIX_FADVISE`
`142`	`144`	`#defineUSE_PREFETCH`

Comments

(0)