NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2af53f3

committed

After closing frontend socket, set MyProcPort->sock = -1 to ensure that

subsequent I/O attempts fail cleanly. I'm speculating about failurescenarios in which we do pq_close, then something in a proc_exit routineopens a file (re-using that kernel FD number), then something elsefails and tries to write an elog message to the frontend ... messageends up in opened file, oops. No known examples of this but it seemslike a potential hole.

1 parent39725e5 commit2af53f3Copy full SHA for 2af53f3

File tree

1 file changed

-1

lines changed

src/backend/libpq
- pqcomm.c

1 file changed

-1

lines changed

`‎src/backend/libpq/pqcomm.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`* Portions Copyright (c) 1996-2000, PostgreSQL, Inc`
`30`	`30`	`* Portions Copyright (c) 1994, Regents of the University of California`
`31`	`31`	`*`
`32`		`- *$Id: pqcomm.c,v 1.91 2000/05/21 21:19:53 tgl Exp $`
	`32`	`+ *$Id: pqcomm.c,v 1.92 2000/05/26 01:26:19 tgl Exp $`
`33`	`33`	`*`
`34`	`34`	`*-------------------------------------------------------------------------`
`35`	`35`	`*/`
`@@ -144,7 +144,11 @@ void`
`144`	`144`	`pq_close(void)`
`145`	`145`	`{`
`146`	`146`	`if (MyProcPort!=NULL)`
	`147`	`+{`
`147`	`148`	`close(MyProcPort->sock);`
	`149`	`+/* make sure any subsequent attempts to do I/O fail cleanly */`
	`150`	`+MyProcPort->sock=-1;`
	`151`	`+}`
`148`	`152`	`}`
`149`	`153`
`150`	`154`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2af53f3

File tree

1 file changed

1 file changed

`‎src/backend/libpq/pqcomm.c`

0 commit comments