NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2aca19f

committed

Use WaitLatch() instead of pg_usleep() at the end of backups

This concerns pg_stop_backup() and BASE_BACKUP, when waiting for theWAL segments required for a backup to be archived. This simplifies abit the handling of the wait event used in this code path.Author: Bharath RupireddyReviewed-by: Michael Paquier, Stephen FrostDiscussion:https://postgr.es/m/CALj2ACU4AdPCq6NLfcA-ZGwX7pPCK5FgEj-CAU0xCKzkASSy_A@mail.gmail.com

1 parent9753324 commit2aca19fCopy full SHA for 2aca19f

File tree

1 file changed

-3

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-3

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -11638,9 +11638,11 @@ do_pg_stop_backup(char labelfile, bool waitforarchive, TimeLineID stoptli_p)`
`11638`	`11638`	`reported_waiting= true;`
`11639`	`11639`	`}`
`11640`	`11640`
`11641`		`-pgstat_report_wait_start(WAIT_EVENT_BACKUP_WAIT_WAL_ARCHIVE);`
`11642`		`-pg_usleep(1000000L);`
`11643`		`-pgstat_report_wait_end();`
	`11641`	`+(void)WaitLatch(MyLatch,`
	`11642`	`+WL_LATCH_SET \|WL_TIMEOUT \|WL_EXIT_ON_PM_DEATH,`
	`11643`	`+1000L,`
	`11644`	`+WAIT_EVENT_BACKUP_WAIT_WAL_ARCHIVE);`
	`11645`	`+ResetLatch(MyLatch);`
`11644`	`11646`
`11645`	`11647`	`if (++waits >=seconds_before_warning)`
`11646`	`11648`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2aca19f

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments