forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit29aeda6
committed
Handle arrays and ranges in pg_upgrade's test for non-upgradable types.
pg_upgrade needs to check whether certain non-upgradable data typesappear anywhere on-disk in the source cluster. It knew that it hasto check for these types being contained inside domains and compositetypes; but it somehow overlooked that they could be contained inarrays and ranges, too. Extend the existing recursive-containmentquery to handle those cases.We probably should have noticed this oversight while working oncommit0ccfc28 and follow-ups, but we failed to :-(. The wholething's possibly a bit overdesigned, since we don't really expectthat any of these types will appear on disk; but if we're going tothe effort of doing a recursive search then it's silly not to coverall the possibilities.While at it, refactor so that we have only one copy of the searchlogic, not three-and-counting. Also, to keep the branches lookingmore alike, back-patch the output wording change of commit1634d36.Back-patch to all supported branches.Discussion:https://postgr.es/m/31473.1573412838@sss.pgh.pa.us1 parent7b8a899 commit29aeda6
1 file changed
+100
-234
lines changed0 commit comments
Comments
(0)