NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit29ab1e2

committed

Enforce child constraints during COPY TO a partitioned table.

The previous coding inadvertently checked the constraints for thepartitioned table rather than the target partition, which couldlead to data in a partition that fails to satisfy some constrainton that partition. This problem seems to date back to whentable partitioning was introduced; prior to that, there was onlyone target table for a COPY, so the problem didn't occur, and thecode just didn't get updated.Etsuro Fujita, reviewed by Amit Langote and Ashutosh BapatDiscussion:https://postgr.es/message-id/5ABA4074.1090500%40lab.ntt.co.jp

1 parentc00c4c5 commit29ab1e2Copy full SHA for 29ab1e2

File tree

1 file changed

-1

lines changed

src/backend/commands
- copy.c

1 file changed

-1

lines changed

`‎src/backend/commands/copy.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2744,7 +2744,8 @@ CopyFrom(CopyState cstate)`
`2744`	`2744`	`check_partition_constr= false;`
`2745`	`2745`
`2746`	`2746`	`/* Check the constraints of the tuple */`
`2747`		`-if (cstate->rel->rd_att->constr\|\|check_partition_constr)`
	`2747`	`+if (resultRelInfo->ri_RelationDesc->rd_att->constr\|\|`
	`2748`	`+check_partition_constr)`
`2748`	`2749`	`ExecConstraints(resultRelInfo,slot,estate);`
`2749`	`2750`
`2750`	`2751`	`if (useHeapMultiInsert)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit29ab1e2

File tree

1 file changed

1 file changed

`‎src/backend/commands/copy.c`

0 commit comments