NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit293fd24

committed

ecpg: remove check_rules.pl.

As noted in the previous commit, check_rules.pl is now entirelyredundant with checks made by parse.pl, or would be if it weren'tfor the places where it's wrong. It's a waste of build cyclesand maintenance effort, so remove it.Discussion:https://postgr.es/m/2011420.1713493114@sss.pgh.pa.us

1 parent00b0e72 commit293fd24Copy full SHA for 293fd24

File tree

3 files changed

-219

lines changed

src/interfaces/ecpg/preproc

3 files changed

-219

lines changed

`‎src/interfaces/ecpg/preproc/Makefile`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,7 @@ preproc.h: preproc.c`
`64`	`64`
`65`	`65`	`preproc.c: BISONFLAGS += -d`
`66`	`66`
`67`		`-preproc.y: ../../../backend/parser/gram.y parse.pl check_rules.pl ecpg.addons ecpg.header ecpg.tokens ecpg.trailer ecpg.type`
`68`		`-$(PERL)$(srcdir)/check_rules.pl --srcdir$(srcdir) --parser$<`
	`67`	`+preproc.y: ../../../backend/parser/gram.y parse.pl ecpg.addons ecpg.header ecpg.tokens ecpg.trailer ecpg.type`
`69`	`68`	`$(PERL)$(srcdir)/parse.pl --srcdir$(srcdir) --parser$< --output$@`
`70`	`69`
`71`	`70`	`# generate keyword headers`

`‎src/interfaces/ecpg/preproc/check_rules.pl`

Lines changed: 0 additions & 202 deletions

This file was deleted.

`‎src/interfaces/ecpg/preproc/meson.build`

Lines changed: 0 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,20 +44,6 @@ preproc_y = custom_target('preproc.y',`
`44`	`44`	`)`
`45`	`45`	`generated_sources+= preproc_y`
`46`	`46`
`47`		`-check_rules=custom_target('preproc.y.check_rules',`
`48`		`-input: [`
`49`		`-'../../../backend/parser/gram.y',`
`50`		`- ecpg_files,`
`51`		`- ],`
`52`		`-output:'preproc.y.check_rules',`
`53`		`-command: [`
`54`		`- perl,files('check_rules.pl'),`
`55`		`-'--srcdir','@CURRENT_SOURCE_DIR@',`
`56`		`-'--parser','@INPUT0@',`
`57`		`-'--stamp','@OUTPUT0@',`
`58`		`- ],`
`59`		`-)`
`60`		`-`
`61`	`47`	`preproc=custom_target('preproc.c',`
`62`	`48`	`input: preproc_y,`
`63`	`49`	`kwargs: bison_kw,`
`@@ -68,7 +54,6 @@ ecpg_sources += preproc`
`68`	`54`	`c_kwlist=custom_target('c_kwlist_d.h',`
`69`	`55`	`input: ['c_kwlist.h'],`
`70`	`56`	`output: ['c_kwlist_d.h'],`
`71`		`-depends: check_rules,`
`72`	`57`	`depend_files: gen_kwlist_deps,`
`73`	`58`	`command: [gen_kwlist_cmd,'--varname','ScanCKeywords','--no-case-fold'],`
`74`	`59`	`)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit293fd24

File tree

3 files changed

3 files changed

`‎src/interfaces/ecpg/preproc/Makefile`

`‎src/interfaces/ecpg/preproc/check_rules.pl`

`‎src/interfaces/ecpg/preproc/meson.build`

0 commit comments