Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit292698f

Browse files
amcheck: Skip unlogged relations in Hot Standby.
Have verify_heapam.c treat unlogged relations as if they were simplyempty when in Hot Standby mode. This brings it in line withverify_nbtree.c, which has handled unlogged relations in the same waysince bugfix commit6754fe6. This was an oversight in commit866e24d, which extended contrib/amcheck to check heap relations.In passing, lower the verbosity used when reporting that a relation hasbeen skipped like this, from NOTICE to DEBUG1. This is appropriatebecause the skipping behavior is only an implementation detail, neededto work around the fact that unlogged tables don't have smgr-levelstorage for their main fork when in Hot Standby mode.Affected unlogged relations should be considered "trivially verified",not skipped over. They are verified in the same sense that a totallyempty relation can be verified. This behavior seems least surprisingoverall, since unlogged relations on a replica will initially be emptyif and when the replica is promoted and Hot Standby ends.Author: Mark Dilger <mark.dilger@enterprisedb.com>Reviewed-By: Peter Geoghegan <pg@bowt.ie>Discussion:https://postgr.es/m/CAH2-Wzk_pukOFY7JmdiFLsrz+Pd3V8OwgC1TH2Vd5BH5ZgK4bA@mail.gmail.comBackpatch: 14-, where heapam verification was introduced.
1 parent4a235ef commit292698f

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

‎contrib/amcheck/verify_heapam.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,22 @@ verify_heapam(PG_FUNCTION_ARGS)
323323
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
324324
errmsg("only heap AM is supported")));
325325

326+
/*
327+
* Early exit for unlogged relations during recovery. These will have no
328+
* relation fork, so there won't be anything to check. We behave as if
329+
* the relation is empty.
330+
*/
331+
if (ctx.rel->rd_rel->relpersistence==RELPERSISTENCE_UNLOGGED&&
332+
RecoveryInProgress())
333+
{
334+
ereport(DEBUG1,
335+
(errcode(ERRCODE_READ_ONLY_SQL_TRANSACTION),
336+
errmsg("cannot verify unlogged relation \"%s\" during recovery, skipping",
337+
RelationGetRelationName(ctx.rel))));
338+
relation_close(ctx.rel,AccessShareLock);
339+
PG_RETURN_NULL();
340+
}
341+
326342
/* Early exit if the relation is empty */
327343
nblocks=RelationGetNumberOfBlocks(ctx.rel);
328344
if (!nblocks)

‎contrib/amcheck/verify_nbtree.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,8 @@ btree_index_checkable(Relation rel)
372372
/*
373373
* Check if B-Tree index relation should have a file for its main relation
374374
* fork. Verification uses this to skip unlogged indexes when in hot standby
375-
* mode, where there is simply nothing to verify.
375+
* mode, where there is simply nothing to verify. We behave as if the
376+
* relation is empty.
376377
*
377378
* NB: Caller should call btree_index_checkable() before calling here.
378379
*/
@@ -383,7 +384,7 @@ btree_index_mainfork_expected(Relation rel)
383384
!RecoveryInProgress())
384385
return true;
385386

386-
ereport(NOTICE,
387+
ereport(DEBUG1,
387388
(errcode(ERRCODE_READ_ONLY_SQL_TRANSACTION),
388389
errmsg("cannot verify unlogged index \"%s\" during recovery, skipping",
389390
RelationGetRelationName(rel))));

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp