NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit28e9ebb

committed

Declare mkdtemp() only if we're providing it.

Follow our usual style of providing an "extern" for a standard libraryfunction only when we're also providing the implementation. This avoidsissues when the system headers declare the function slightly differentlythan we do, as noted by Caleb Welton.We might have to go to the extent of probing to see if the system headersdeclare the function, but let's not do that until it's demonstrated to benecessary.Oversight in commit9e6b1bf. Back-patchto all supported branches, as that was.

1 parent96139cf commit28e9ebbCopy full SHA for 28e9ebb

File tree

1 file changed

-3

lines changed

src/include
- port.h

1 file changed

-3

lines changed

`‎src/include/port.h`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -426,6 +426,10 @@ extern intgetpeereid(int sock, uid_t uid, gid_t gid);`
`426`	`426`	`externintisinf(doublex);`
`427`	`427`	`#endif`
`428`	`428`
	`429`	`+#ifndefHAVE_MKDTEMP`
	`430`	`+externcharmkdtemp(charpath);`
	`431`	`+#endif`
	`432`	`+`
`429`	`433`	`#ifndefHAVE_RINT`
`430`	`434`	`externdoublerint(doublex);`
`431`	`435`	`#endif`
`@@ -497,7 +501,4 @@ extern intpg_check_dir(const char *dir);`
`497`	`501`	`/* port/pgmkdirp.c */`
`498`	`502`	`externintpg_mkdir_p(char*path,intomode);`
`499`	`503`
`500`		`-/* port/mkdtemp.c */`
`501`		`-externcharmkdtemp(charpath);`
`502`		`-`
`503`	`504`	`#endif/* PG_PORT_H */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit28e9ebb

File tree

1 file changed

1 file changed

`‎src/include/port.h`

0 commit comments