Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit28b901f

Browse files
Update obsolete tuplesort READTUP() comment.
READTUP() routines do not and cannot use the resettable "tuplecontext"memory context, since it is deleted when merging begins. Update anobsolete comment that claimed otherwise. This was an oversight incommite94568e.In passing, fix an unrelated tuplesort typo.
1 parent956451e commit28b901f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

‎src/backend/utils/sort/tuplesort.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -574,10 +574,12 @@ struct Sharedsort
574574
* a lot better than what we were doing before 7.3. As of 9.6, a
575575
* separate memory context is used for caller passed tuples. Resetting
576576
* it at certain key increments significantly ameliorates fragmentation.
577-
* Note that this places a responsibility on readtup and copytup routines
578-
* to use the right memory context for these tuples (and to not use the
579-
* reset context for anything whose lifetime needs to span multiple
580-
* external sort runs).
577+
* Note that this places a responsibility on copytup routines to use the
578+
* correct memory context for these tuples (and to not use the reset
579+
* context for anything whose lifetime needs to span multiple external
580+
* sort runs). readtup routines use the slab allocator (they cannot use
581+
* the reset context because it gets deleted at the point that merging
582+
* begins).
581583
*/
582584

583585
/* When using this macro, beware of double evaluation of len */
@@ -1148,7 +1150,7 @@ tuplesort_begin_datum(Oid datumType, Oid sortOperator, Oid sortCollation,
11481150
* Abbreviation is possible here only for by-reference types. In theory,
11491151
* a pass-by-value datatype could have an abbreviated form that is cheaper
11501152
* to compare. In a tuple sort, we could support that, because we can
1151-
* always extract the original datum from the tupleis needed. Here, we
1153+
* always extract the original datum from the tupleas needed. Here, we
11521154
* can't, because a datum sort only stores a single copy of the datum; the
11531155
* "tuple" field of each sortTuple is NULL.
11541156
*/
@@ -2821,7 +2823,6 @@ mergeonerun(Tuplesortstate *state)
28212823
{
28222824
stup.tupindex=srcTape;
28232825
tuplesort_heap_replace_top(state,&stup);
2824-
28252826
}
28262827
else
28272828
tuplesort_heap_delete_top(state);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp