Commit28b3a3d

committed

to_number(): allow 'V' to divide by 10^(the number of digits)

to_char('V') already multiplied in a similar manner.Report by Jeremy Lowery

1 parent2145a76 commit28b3a3dCopy full SHA for 28b3a3d

File tree

+23

-4

lines changed

+23

-4

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -6152,12 +6152,14 @@ SELECT regexp_matches('abc01234xyz', '(?:(.?)(\d+)(.)){1,1}');`
`6152`	`6152`
`6153`	`6153`	`<listitem>`
`6154`	`6154`	`<para>`
`6155`		`- <literal>V</literal>effectively`
	`6155`	`+ <literal>V</literal>with <function>to_char</function>`
`6156`	`6156`	`multiplies the input values by`
`6157`	`6157`	`<literal>10^<replaceable>n</replaceable></literal>, where`
`6158`	`6158`	`<replaceable>n</replaceable> is the number of digits following`
`6159`		`- <literal>V</literal>.`
`6160`		`- <function>to_char</function> does not support the use of`
	`6159`	`+ <literal>V</literal>. <literal>V</literal> with`
	`6160`	`+ <function>to_number</function> divides in a similar manner.`
	`6161`	`+ <function>to_char</function> and <function>to_number</function>`
	`6162`	`+ do not support the use of`
`6161`	`6163`	`<literal>V</literal> combined with a decimal point`
`6162`	`6164`	`(e.g., <literal>99.9V99</literal> is not allowed).`
`6163`	`6165`	`</para>`

Lines changed: 18 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5055,7 +5055,7 @@ numeric_to_number(PG_FUNCTION_ARGS)`
`5055`	`5055`	`VARSIZE(value)-VARHDRSZ,0,0, false,PG_GET_COLLATION());`
`5056`	`5056`
`5057`	`5057`	`scale=Num.post;`
`5058`		`-precision=Max(0,Num.pre)+scale;`
	`5058`	`+precision=Num.pre+Num.multi+scale;`
`5059`	`5059`
`5060`	`5060`	`if (shouldFree)`
`5061`	`5061`	`pfree(format);`
`@@ -5064,6 +5064,23 @@ numeric_to_number(PG_FUNCTION_ARGS)`
`5064`	`5064`	`CStringGetDatum(numstr),`
`5065`	`5065`	`ObjectIdGetDatum(InvalidOid),`
`5066`	`5066`	`Int32GetDatum(((precision <<16) \|scale)+VARHDRSZ));`
	`5067`	`+`
	`5068`	`+if (IS_MULTI(&Num))`
	`5069`	`+{`
	`5070`	`+Numericx;`
	`5071`	`+Numerica=DatumGetNumeric(DirectFunctionCall1(int4_numeric,`
	`5072`	`+Int32GetDatum(10)));`
	`5073`	`+Numericb=DatumGetNumeric(DirectFunctionCall1(int4_numeric,`
	`5074`	`+Int32GetDatum(-Num.multi)));`
	`5075`	`+`
	`5076`	`+x=DatumGetNumeric(DirectFunctionCall2(numeric_power,`
	`5077`	`+NumericGetDatum(a),`
	`5078`	`+NumericGetDatum(b)));`
	`5079`	`+result=DirectFunctionCall2(numeric_mul,`
	`5080`	`+result,`
	`5081`	`+NumericGetDatum(x));`
	`5082`	`+}`
	`5083`	`+`
`5067`	`5084`	`pfree(numstr);`
`5068`	`5085`	`returnresult;`
`5069`	`5086`	`}`

Comments

(0)