NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2897e06

committed

Fix rare core dump in BackendIdGetTransactionIds().

BackendIdGetTransactionIds() neglected the possibility that the PROCpointer in a ProcState array entry is null. In current usage, this couldonly crash if the other backend had exited since pgstat_read_current_statussaw it as active, which is a pretty narrow window. But it's reachable inthe field, per bug #12918 from Vladimir Borodin.Back-patch to 9.4 where the faulty code was introduced.

1 parentf444de5 commit2897e06Copy full SHA for 2897e06

File tree

1 file changed

-6

lines changed

src/backend/storage/ipc
- sinvaladt.c

1 file changed

-6

lines changed

`‎src/backend/storage/ipc/sinvaladt.c`

Lines changed: 9 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -410,9 +410,7 @@ BackendIdGetProc(int backendID)`
`410`	`410`	`void`
`411`	`411`	`BackendIdGetTransactionIds(intbackendID,TransactionIdxid,TransactionIdxmin)`
`412`	`412`	`{`
`413`		`-ProcState*stateP;`
`414`	`413`	`SISeg*segP=shmInvalBuffer;`
`415`		`-PGXACT*xact;`
`416`	`414`
`417`	`415`	`*xid=InvalidTransactionId;`
`418`	`416`	`*xmin=InvalidTransactionId;`
`@@ -422,11 +420,16 @@ BackendIdGetTransactionIds(int backendID, TransactionId xid, TransactionId xmi`
`422`	`420`
`423`	`421`	`if (backendID>0&&backendID <=segP->lastBackend)`
`424`	`422`	`{`
`425`		`-stateP=&segP->procState[backendID-1];`
`426`		`-xact=&ProcGlobal->allPgXact[stateP->proc->pgprocno];`
	`423`	`+ProcState*stateP=&segP->procState[backendID-1];`
	`424`	`+PGPROC*proc=stateP->proc;`
`427`	`425`
`428`		`-*xid=xact->xid;`
`429`		`-*xmin=xact->xmin;`
	`426`	`+if (proc!=NULL)`
	`427`	`+{`
	`428`	`+PGXACT*xact=&ProcGlobal->allPgXact[proc->pgprocno];`
	`429`	`+`
	`430`	`+*xid=xact->xid;`
	`431`	`+*xmin=xact->xmin;`
	`432`	`+}`
`430`	`433`	`}`
`431`	`434`
`432`	`435`	`LWLockRelease(SInvalWriteLock);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2897e06

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/sinvaladt.c`

0 commit comments