NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit28644fa

committed

Don't leak rd_statlist when a relcache entry is dropped.

Although these lists are usually NIL, and even when not emptyare unlikely to be large, constant relcache update traffic couldeventually result in visible bloat of CacheMemoryContext.Found via valgrind testing.Back-patch to v10 where this field was added.Discussion:https://postgr.es/m/3816764.1616104288@sss.pgh.pa.us

1 parenta16b2b9 commit28644faCopy full SHA for 28644fa

File tree

1 file changed

-0

lines changed

src/backend/utils/cache
- relcache.c

1 file changed

-0

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2392,6 +2392,7 @@ RelationDestroyRelation(Relation relation, bool remember_tupdesc)`
`2392`	`2392`	`FreeTriggerDesc(relation->trigdesc);`
`2393`	`2393`	`list_free_deep(relation->rd_fkeylist);`
`2394`	`2394`	`list_free(relation->rd_indexlist);`
	`2395`	`+list_free(relation->rd_statlist);`
`2395`	`2396`	`bms_free(relation->rd_indexattr);`
`2396`	`2397`	`bms_free(relation->rd_keyattr);`
`2397`	`2398`	`bms_free(relation->rd_pkattr);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit28644fa

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/relcache.c`

0 commit comments