Commit27f3bbf

committed

Fixes in bloom contrib module missed during review

- macroses llike (var & FLAG) are changed to ((var & FLAG) != 0)- do not copy uninitialized part of notFullPage array to page

1 parentf402b99 commit27f3bbfCopy full SHA for 27f3bbf

File tree

-5

lines changed

-5

lines changed

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,10 +44,14 @@ typedef BloomPageOpaqueData *BloomPageOpaque;`
`44`	`44`	`/* Macros for accessing bloom page structures */`
`45`	`45`	`#defineBloomPageGetOpaque(page) ((BloomPageOpaque) PageGetSpecialPointer(page))`
`46`	`46`	`#defineBloomPageGetMaxOffset(page) (BloomPageGetOpaque(page)->maxoff)`
`47`		`-#defineBloomPageIsMeta(page) (BloomPageGetOpaque(page)->flags & BLOOM_META)`
`48`		`-#defineBloomPageIsDeleted(page) (BloomPageGetOpaque(page)->flags & BLOOM_DELETED)`
`49`		`-#defineBloomPageSetDeleted(page) (BloomPageGetOpaque(page)->flags \|= BLOOM_DELETED)`
`50`		`-#defineBloomPageSetNonDeleted(page) (BloomPageGetOpaque(page)->flags &= ~BLOOM_DELETED)`
	`47`	`+#defineBloomPageIsMeta(page) \`
	`48`	`+((BloomPageGetOpaque(page)->flags & BLOOM_META) != 0)`
	`49`	`+#defineBloomPageIsDeleted(page) \`
	`50`	`+((BloomPageGetOpaque(page)->flags & BLOOM_DELETED) != 0)`
	`51`	`+#defineBloomPageSetDeleted(page) \`
	`52`	`+(BloomPageGetOpaque(page)->flags \|= BLOOM_DELETED)`
	`53`	`+#defineBloomPageSetNonDeleted(page) \`
	`54`	`+(BloomPageGetOpaque(page)->flags &= ~BLOOM_DELETED)`
`51`	`55`	`#defineBloomPageGetData(page)((BloomTuple *)PageGetContents(page))`
`52`	`56`	`#defineBloomPageGetTuple(state,page,offset) \`
`53`	`57`	`((BloomTuple *)(PageGetContents(page) \`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ blbulkdelete(IndexVacuumInfo info, IndexBulkDeleteResult stats,`
`142`	`142`	`page=GenericXLogRegister(gxlogState,buffer, false);`
`143`	`143`
`144`	`144`	`metaData=BloomPageGetMeta(page);`
`145`		`-memcpy(metaData->notFullPage,notFullPage,sizeof(FreeBlockNumberArray));`
	`145`	`+memcpy(metaData->notFullPage,notFullPage,sizeof(BlockNumber)*countPage);`
`146`	`146`	`metaData->nStart=0;`
`147`	`147`	`metaData->nEnd=countPage;`
`148`	`148`

Comments

(0)