Commit27eeca5

committed

For GUC values, check for partial string matches on 'on' and 'off', but

require at least two characters for uniqueness. This now matches thebehavior of other boolean strings we support, per report from GurjeetSingh.

1 parenta78fcfb commit27eeca5Copy full SHA for 27eeca5

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Written by Peter Eisentraut <peter_e@gmx.net>.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.362 2006/12/13 05:54:48 tgl Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.363 2006/12/23 00:52:40 momjian Exp $`
`14`	`14`	`*`
`15`	`15`	`*--------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -3575,12 +3575,13 @@ parse_bool(const char value, bool result)`
`3575`	`3575`	`*result= false;`
`3576`	`3576`	`}`
`3577`	`3577`
`3578`		`-elseif (pg_strcasecmp(value,"on")==0)`
	`3578`	`+/* 'o' is not unique enough */`
	`3579`	`+elseif (pg_strncasecmp(value,"on", (len>2 ?len :2))==0)`
`3579`	`3580`	`{`
`3580`	`3581`	`if (result)`
`3581`	`3582`	`*result= true;`
`3582`	`3583`	`}`
`3583`		`-elseif (pg_strcasecmp(value,"off")==0)`
	`3584`	`+elseif (pg_strncasecmp(value,"off", (len>2 ?len :2))==0)`
`3584`	`3585`	`{`
`3585`	`3586`	`if (result)`
`3586`	`3587`	`*result= false;`

Comments

(0)