Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit27b3324

Browse files
committed
Fix pg_dumpall to work for databases flagged as read-only.
pg_dumpall's charter is to be able to recreate a database cluster'scontents in a virgin installation, but it was failing to honor thatcontract if the cluster had any ALTER DATABASE SETdefault_transaction_read_only settings. By including a SET commandfor the connection for each connection opened by pg_dumpall output,errors are avoided and the source cluster is successfullyrecreated.There was discussion of whether to also set this for the connectionapplying pg_dump output, but it was felt that it was both lessappropriate in that context, and far easier to work around.Backpatch to all supported branches.
1 parent8f8c666 commit27b3324

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

‎src/bin/pg_dump/pg_dumpall.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,9 @@ main(int argc, char *argv[])
448448
* database we're connected to at the moment is fine.
449449
*/
450450

451+
/* Restore will need to write to the target cluster */
452+
fprintf(OPF,"SET default_transaction_read_only = off;\n\n");
453+
451454
/* Replicate encoding and std_strings in output */
452455
fprintf(OPF,"SET client_encoding = '%s';\n",
453456
pg_encoding_to_char(encoding));
@@ -1586,6 +1589,17 @@ dumpDatabases(PGconn *conn)
15861589

15871590
fprintf(OPF,"\\connect %s\n\n",fmtId(dbname));
15881591

1592+
/*
1593+
* Restore will need to write to the target cluster. This connection
1594+
* setting is emitted for pg_dumpall rather than in the code also used
1595+
* by pg_dump, so that a cluster with databases or users which have
1596+
* this flag turned on can still be replicated through pg_dumpall
1597+
* without editing the file or stream. With pg_dump there are many
1598+
* other ways to allow the file to be used, and leaving it out allows
1599+
* users to protect databases from being accidental restore targets.
1600+
*/
1601+
fprintf(OPF,"SET default_transaction_read_only = off;\n\n");
1602+
15891603
if (filename)
15901604
fclose(OPF);
15911605

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp