NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2712da8

committed

Generate pg_basebackup temporary slot name using backend pid

Using the client pid can easily be non-unique when used on differenthosts. Using the backend pid should be guaranteed unique, since thetemporary slot gets removed when the client disconnects so it will begone even if the pid is renewed.Reported by Ludovic Vaugeois-Pepin

1 parent814573e commit2712da8Copy full SHA for 2712da8

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- pg_basebackup.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -493,7 +493,7 @@ LogStreamerMain(logstreamer_param *param)`
`493`	`493`	`stream.replication_slot=replication_slot;`
`494`	`494`	`stream.temp_slot=param->temp_slot;`
`495`	`495`	`if (stream.temp_slot&& !stream.replication_slot)`
`496`		`-stream.replication_slot=psprintf("pg_basebackup_%d", (int)getpid());`
	`496`	`+stream.replication_slot=psprintf("pg_basebackup_%d", (int)PQbackendPID(param->bgconn));`
`497`	`497`
`498`	`498`	`if (format=='p')`
`499`	`499`	`stream.walmethod=CreateWalDirectoryMethod(param->xlog,0,do_sync);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2712da8

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

0 commit comments