NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2704898

committed

Re-enable error for "SELECT ... OFFSET -1".

The executor has thrown errors for negative OFFSET values since 8.4 (seecommitbfce56e), but in a moment of brainfade I taught the planner that OFFSET with a constant negative value was ano-op (commit1a1832e). Reinstate theformer behavior by only discarding OFFSET with a value of exactly 0. Inpassing, adjust a planner comment that referenced the ancient behavior.Back-patch to 9.3 where the mistake was introduced.

1 parent27cef0a commit2704898Copy full SHA for 2704898

File tree

1 file changed

-4

lines changed

src/backend/optimizer/plan
- planner.c

1 file changed

-4

lines changed

`‎src/backend/optimizer/plan/planner.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2335,7 +2335,7 @@ preprocess_limit(PlannerInfo *root, double tuple_fraction,`
`2335`	`2335`	`{`
`2336`	`2336`	`offset_est=DatumGetInt64(((Const)est)->constvalue);`
`2337`	`2337`	`if (*offset_est<0)`
`2338`		`-offset_est=0;/less than 0 is sameas0 */`
	`2338`	`+offset_est=0;/treatasnot present */`
`2339`	`2339`	`}`
`2340`	`2340`	`}`
`2341`	`2341`	`else`
`@@ -2496,9 +2496,8 @@ limit_needed(Query *parse)`
`2496`	`2496`	`{`
`2497`	`2497`	`int64offset=DatumGetInt64(((Const*)node)->constvalue);`
`2498`	`2498`
`2499`		`-/* Executor would treat less-than-zero same as zero */`
`2500`		`-if (offset>0)`
`2501`		`-return true;/* OFFSET with a positive value */`
	`2499`	`+if (offset!=0)`
	`2500`	`+return true;/* OFFSET with a nonzero value */`
`2502`	`2501`	`}`
`2503`	`2502`	`}`
`2504`	`2503`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2704898

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/planner.c`

0 commit comments