Commit2673ebf

committed

Remove redundant setting of tuplesort status

Also add an explanatory comment to match other similar coding withintuplesort_performsort().Xing GuoReviewed by Richard Guo and Cary HuangDiscussion:https://www.postgresql.org/message-id/CACpMh%2BAQ4GXRKKi9ib2ioUH%2BqwNaSAVbetssJ0tMPfxAWuL2yg%40mail.gmail.com

1 parentc06caa0 commit2673ebfCopy full SHA for 2673ebf

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1439,13 +1439,13 @@ tuplesort_performsort(Tuplesortstate *state)`
`1439`	`1439`	`* We were able to accumulate all the tuples required for output`
`1440`	`1440`	`* in memory, using a heap to eliminate excess tuples. Now we`
`1441`	`1441`	`* have to transform the heap to a properly-sorted array.`
	`1442`	`+ * Note that sort_bounded_heap sets the correct state->status.`
`1442`	`1443`	`*/`
`1443`	`1444`	`sort_bounded_heap(state);`
`1444`	`1445`	`state->current=0;`
`1445`	`1446`	`state->eof_reached= false;`
`1446`	`1447`	`state->markpos_offset=0;`
`1447`	`1448`	`state->markpos_eof= false;`
`1448`		`-state->status=TSS_SORTEDINMEM;`
`1449`	`1449`	`break;`
`1450`	`1450`
`1451`	`1451`	`caseTSS_BUILDRUNS:`

Comments

(0)