NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit25ec484

committed

This patch adds reporting of tcl global variable errorInfo

which contains stack trace. One problem, after this patch errors will generate multiline ERRORmessages. Is it acceptable or do I need split it and generate multiplesingleline messages?Vsevolod Lobko

1 parent6055333 commit25ec484Copy full SHA for 25ec484

File tree

1 file changed

+11

-3

lines changed

src/pl/tcl
- pltcl.c

1 file changed

+11

-3

lines changed

`‎src/pl/tcl/pltcl.c`

Lines changed: 11 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`* ENHANCEMENTS, OR MODIFICATIONS.`
`32`	`32`	`*`
`33`	`33`	`* IDENTIFICATION`
`34`		`- * $Header: /cvsroot/pgsql/src/pl/tcl/pltcl.c,v 1.40 2001/10/01 15:33:31 momjian Exp $`
	`34`	`+ * $Header: /cvsroot/pgsql/src/pl/tcl/pltcl.c,v 1.41 2001/10/04 15:47:41 momjian Exp $`
`35`	`35`	`*`
`36`	`36`	`**********************************************************************/`
`37`	`37`
`@@ -789,7 +789,11 @@ pltcl_func_handler(PG_FUNCTION_ARGS)`
`789`	`789`	`pltcl_restart_in_progress=1;`
`790`	`790`	`if (--pltcl_call_level==0)`
`791`	`791`	`pltcl_restart_in_progress=0;`
`792`		`-elog(ERROR,"pltcl: %s",interp->result);`
	`792`	`+UTF_BEGIN;`
	`793`	`+elog(ERROR,"pltcl: %s\n%s",interp->result,`
	`794`	`+UTF_U2E(Tcl_GetVar(interp,"errorInfo",`
	`795`	`+TCL_GLOBAL_ONLY)));`
	`796`	`+UTF_END;`
`793`	`797`	`}`
`794`	`798`	`if (--pltcl_call_level==0)`
`795`	`799`	`pltcl_restart_in_progress=0;`
`@@ -1162,7 +1166,11 @@ pltcl_trigger_handler(PG_FUNCTION_ARGS)`
`1162`	`1166`	`pltcl_restart_in_progress=1;`
`1163`	`1167`	`if (--pltcl_call_level==0)`
`1164`	`1168`	`pltcl_restart_in_progress=0;`
`1165`		`-elog(ERROR,"pltcl: %s",interp->result);`
	`1169`	`+UTF_BEGIN;`
	`1170`	`+elog(ERROR,"pltcl: %s\n%s",interp->result,`
	`1171`	`+UTF_U2E(Tcl_GetVar(interp,"errorInfo",`
	`1172`	`+TCL_GLOBAL_ONLY)));`
	`1173`	`+UTF_END;`
`1166`	`1174`	`}`
`1167`	`1175`	`if (--pltcl_call_level==0)`
`1168`	`1176`	`pltcl_restart_in_progress=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit25ec484

File tree

1 file changed

1 file changed

`‎src/pl/tcl/pltcl.c`

0 commit comments