NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit25d1ef1

committed

Ensure pg_filenode_relation(0, 0) returns NULL.

Previously, a zero value for the relfilenode resulted ina confusing error message about "unexpected duplicate".This function returns NULL for other invalid relfilenodevalues, so zero should be treated likewise.It's been like this all along, so back-patch to all supportedbranches.Justin PryzbyDiscussion:https://postgr.es/m/20210612023324.GT16435@telsasoft.com

1 parent9eecea7 commit25d1ef1Copy full SHA for 25d1ef1

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- dbsize.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/dbsize.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -921,7 +921,11 @@ pg_filenode_relation(PG_FUNCTION_ARGS)`
`921`	`921`	`{`
`922`	`922`	`Oidreltablespace=PG_GETARG_OID(0);`
`923`	`923`	`Oidrelfilenode=PG_GETARG_OID(1);`
`924`		`-Oidheaprel=InvalidOid;`
	`924`	`+Oidheaprel;`
	`925`	`+`
	`926`	`+/* test needed so RelidByRelfilenode doesn't misbehave */`
	`927`	`+if (!OidIsValid(relfilenode))`
	`928`	`+PG_RETURN_NULL();`
`925`	`929`
`926`	`930`	`heaprel=RelidByRelfilenode(reltablespace,relfilenode);`
`927`	`931`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit25d1ef1

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/dbsize.c`

0 commit comments