NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit25c7faa

committed

Fix datatype confusion in logtape.c's right_offset().

This could only matter if (a) long is wider than int, and (b) the heapof free blocks exceeds UINT_MAX entries, which seems pretty unlikely.Still, it's a theoretical bug, so backpatch to v13 where the typo camein (in commitc02fdc9).In passing, also make swap_nodes() use consistent datatypes.Ma LiangzhuDiscussion:https://postgr.es/m/17336-fc4e522d26a750fd@postgresql.org

1 parent4be3e00 commit25c7faaCopy full SHA for 25c7faa

File tree

1 file changed

-2

lines changed

src/backend/utils/sort
- logtape.c

1 file changed

-2

lines changed

`‎src/backend/utils/sort/logtape.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ ltsReadFillBuffer(LogicalTapeSet lts, LogicalTape lt)`
`345`	`345`	`staticinlinevoid`
`346`	`346`	`swap_nodes(long*heap,unsigned longa,unsigned longb)`
`347`	`347`	`{`
`348`		`-unsignedlongswap;`
	`348`	`+longswap;`
`349`	`349`
`350`	`350`	`swap=heap[a];`
`351`	`351`	`heap[a]=heap[b];`
`@@ -359,7 +359,7 @@ left_offset(unsigned long i)`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`staticinlineunsigned long`
`362`		`-right_offset(unsignedi)`
	`362`	`+right_offset(unsignedlongi)`
`363`	`363`	`{`
`364`	`364`	`return2*i+2;`
`365`	`365`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit25c7faa

File tree

1 file changed

1 file changed

`‎src/backend/utils/sort/logtape.c`

0 commit comments