NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit259bbe1

committed

Fix base backup with database OIDs larger than INT32_MAX

The use of pg_atoi() for parsing a string into an Oid fails for valueslarger than INT32_MAX, since OIDs are unsigned. Instead, useatooid(). While this has less error checking, the contents of thedata directory are expected to be trustworthy, so we don't need to goout of our way to do full error checking.Discussion:https://www.postgresql.org/message-id/flat/dea47fc8-6c89-a2b1-07e3-754ff1ab094b%402ndquadrant.com

1 parent23d0dfa commit259bbe1Copy full SHA for 259bbe1

File tree

1 file changed

-1

lines changed

src/backend/replication
- basebackup.c

1 file changed

-1

lines changed

`‎src/backend/replication/basebackup.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1291,7 +1291,7 @@ sendDir(const char path, int basepathlen, bool sizeonly, List tablespaces,`
`1291`	`1291`
`1292`	`1292`	`if (!sizeonly)`
`1293`	`1293`	`sent=sendFile(pathbuf,pathbuf+basepathlen+1,&statbuf,`
`1294`		`-true,isDbDir ?pg_atoi(lastDir+1,sizeof(Oid),0) :InvalidOid);`
	`1294`	`+true,isDbDir ?atooid(lastDir+1) :InvalidOid);`
`1295`	`1295`
`1296`	`1296`	`if (sent\|\|sizeonly)`
`1297`	`1297`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit259bbe1

File tree

1 file changed

1 file changed

`‎src/backend/replication/basebackup.c`

0 commit comments