Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit255625d

Browse files
committed
Use a short socket directory path in pg_upgrade testing.
Several buildfarm members are failing the pg_upgrade test inREL_15_STABLE, though the identical test is fine in HEAD.On thorntail it's possible to see that the problem is anoverlength socket path name, and I bet the same is trueon the others.The normally-started postmasters used in the test are alreadyset up with short socket directory paths, but we neglected totell pg_upgrade itself to do likewise when starting childpostmasters, and indeed it seems to be explicitly selectingthe test directory instead.Back-patch to v15 where the current test script was introduced.(The previous script might have the same issue, because I don'tsee any use of -s/--socketdir in it either; but we've had nocomplaints, so leave it alone for now.)Discussion:https://postgr.es/m/1410025.1656890531@sss.pgh.pa.us
1 parent89a39d4 commit255625d

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

‎src/bin/pg_upgrade/t/002_pg_upgrade.pl

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ sub generate_db
226226
'-D',$newnode->data_dir,
227227
'-b',$oldbindir .'/does/not/exist/',
228228
'-B',$newbindir,
229+
'-s',$newnode->host,
229230
'-p',$oldnode->port,
230231
'-P',$newnode->port,
231232
'--check'
@@ -240,8 +241,9 @@ sub generate_db
240241
[
241242
'pg_upgrade','--no-sync','-d',$oldnode->data_dir,
242243
'-D',$newnode->data_dir,'-b',$oldbindir,
243-
'-B',$newbindir,'-p',$oldnode->port,
244-
'-P',$newnode->port,'--check'
244+
'-B',$newbindir,'-s',$newnode->host,
245+
'-p',$oldnode->port,'-P',$newnode->port,
246+
'--check'
245247
],
246248
'run of pg_upgrade --check for new instance');
247249
ok(!-d$newnode->data_dir ."/pg_upgrade_output.d",
@@ -252,8 +254,8 @@ sub generate_db
252254
[
253255
'pg_upgrade','--no-sync','-d',$oldnode->data_dir,
254256
'-D',$newnode->data_dir,'-b',$oldbindir,
255-
'-B',$newbindir,'-p',$oldnode->port,
256-
'-P',$newnode->port
257+
'-B',$newbindir,'-s',$newnode->host,
258+
'-p',$oldnode->port,'-P',$newnode->port
257259
],
258260
'run of pg_upgrade for new instance');
259261
ok( !-d$newnode->data_dir ."/pg_upgrade_output.d",

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp