NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit25560fd

committed

Fix bufmgr so CHECKPOINT_END_OF_RECOVERY behaves as a shutdown checkpoint.

Recovery code documents clearly that a shutdown checkpoint is executed atend of recovery - a shutdown checkpoint WAL record is written but the buffermanager had been altered to treat end of recovery as a normal checkpoint.This bug exacerbates the bufmgr relpersistence bug.Bug spotted by Andres Freund, patch by me.

1 parent5752e1b commit25560fdCopy full SHA for 25560fd

File tree

1 file changed

-2

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-2

lines changed

`‎src/backend/storage/buffer/bufmgr.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1183,9 +1183,9 @@ BufferSync(int flags)`
`1183`	`1183`
`1184`	`1184`	`/*`
`1185`	`1185`	`* Unless this is a shutdown checkpoint, we write only permanent, dirty`
`1186`		`- * buffers. But at shutdowntime, we write all dirty buffers.`
	`1186`	`+ * buffers. But at shutdownor end of recovery, we write all dirty buffers.`
`1187`	`1187`	`*/`
`1188`		`-if (!(flags&CHECKPOINT_IS_SHUTDOWN))`
	`1188`	`+if (!((flags&CHECKPOINT_IS_SHUTDOWN)\|\| (flags&CHECKPOINT_END_OF_RECOVERY)))`
`1189`	`1189`	`mask \|=BM_PERMANENT;`
`1190`	`1190`
`1191`	`1191`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit25560fd

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c‎`

0 commit comments