forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit245de48
committed
Adjust MSVC build scripts to parse Makefiles for defines
This adjusts the MSVC build scripts to look at the compile flags mentionedin the Makefile to look for -D arguments in order to determine whichconstants should be defined in Visual Studio builds.One small anomaly that appeared as a result of this change is that theMakefile for the ltree contrib module defined LOWER_NODE, but this wasnot properly defined in the MSVC build scripts. This meant that MSVCbuilds would differ in case sensitivity in the ltree module whencompared to builds using a make build environment. To maintain the samebehavior here we remove the -DLOWER_NODE from the Makefile and just alwaysdefine it in ltree.h for non-MSVC builds. We need to maintain the oldbehavior here as this affects the on-disk compatibility of GiST indexeswhen using the ltree type.The only other resulting change here is that REFINT_VERBOSE is now definedfor the autoinc, insert_username and moddatetime contrib modules.Previously on MSVC, this was only defined for the refint module. Thisaligns the behavior to build environments using make as all 4 of thesemodules share the same Makefile.Reviewed-by: Tom LaneDiscussion:https://postgr.es/m/CAApHDvpo6g5csCTjc_0C7DMvgFPomVb0Rh-AcW5afd=Ya=LRuw@mail.gmail.com1 parent15f16ec commit245de48
File tree
4 files changed
+34
-2
lines changed- contrib/ltree
- src/tools/msvc
4 files changed
+34
-2
lines changedOriginal file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
12 | 12 |
| |
13 | 13 |
| |
14 | 14 |
| |
15 |
| - | |
16 | 15 |
| |
17 | 16 |
| |
18 | 17 |
| |
|
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
8 | 8 |
| |
9 | 9 |
| |
10 | 10 |
| |
| 11 | + | |
11 | 12 |
| |
12 | 13 |
| |
13 | 14 |
| |
|
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
17 | 17 |
| |
18 | 18 |
| |
19 | 19 |
| |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
20 | 33 |
| |
21 | 34 |
| |
22 | 35 |
| |
|
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
35 | 35 |
| |
36 | 36 |
| |
37 | 37 |
| |
38 |
| - | |
| 38 | + | |
39 | 39 |
| |
40 | 40 |
| |
41 | 41 |
| |
| |||
964 | 964 |
| |
965 | 965 |
| |
966 | 966 |
| |
| 967 | + | |
967 | 968 |
| |
968 | 969 |
| |
969 | 970 |
| |
970 | 971 |
| |
971 | 972 |
| |
972 | 973 |
| |
973 | 974 |
| |
| 975 | + | |
974 | 976 |
| |
975 | 977 |
| |
976 | 978 |
| |
| |||
982 | 984 |
| |
983 | 985 |
| |
984 | 986 |
| |
| 987 | + | |
985 | 988 |
| |
986 | 989 |
| |
987 | 990 |
| |
988 | 991 |
| |
989 | 992 |
| |
990 | 993 |
| |
| 994 | + | |
991 | 995 |
| |
992 | 996 |
| |
993 | 997 |
| |
994 | 998 |
| |
995 | 999 |
| |
996 | 1000 |
| |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
997 | 1016 |
| |
998 | 1017 |
| |
999 | 1018 |
| |
|
0 commit comments
Comments
(0)