NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit24566b3

committed

Attempt to fix unstable regression tests, take 2

Following up on2dc16ef, petalura has suffered some additionalfailures in stats_ext which again appear to be around the timing of anautovacuum during the test, causing instability in the row estimates.Again, let's fix this by explicitly performing a VACUUM on the tableand not leave it to happen by chance of an autovacuum pass.Discussion:https://postgr.es/m/CAApHDvok5hmXr%2BbUbJe7%2B2sQzWo4B_QzSk7RKFR9fP6BjYXx5g%40mail.gmail.com

1 parent64638cc commit24566b3Copy full SHA for 24566b3

File tree

2 files changed

+10

-10

lines changed

src/test/regress
- expected
  - stats_ext.out
- sql
  - stats_ext.sql

2 files changed

+10

-10

lines changed

`‎src/test/regress/expected/stats_ext.out`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ INSERT INTO ndistinct (a, b, c, filler1)`
`279`	`279`	`SELECT mod(i,50), mod(i,51), mod(i,32),`
`280`	`280`	`cash_words(mod(i,33)::int::money)`
`281`	`281`	`FROM generate_series(1,5000) s(i);`
`282`		`-ANALYZE ndistinct;`
	`282`	`+VACUUM (ANALYZE) ndistinct;`
`283`	`283`	`SELECT s.stxkind, d.stxdndistinct`
`284`	`284`	`FROM pg_statistic_ext s, pg_statistic_ext_data d`
`285`	`285`	`WHERE s.stxrelid = 'ndistinct'::regclass`
`@@ -375,7 +375,7 @@ CREATE INDEX fdeps_abc_idx ON functional_dependencies (a, b, c);`
`375`	`375`	`-- random data (no functional dependencies)`
`376`	`376`	`INSERT INTO functional_dependencies (a, b, c, filler1)`
`377`	`377`	`SELECT mod(i, 23), mod(i, 29), mod(i, 31), i FROM generate_series(1,5000) s(i);`
`378`		`-ANALYZE functional_dependencies;`
	`378`	`+VACUUM (ANALYZE) functional_dependencies;`
`379`	`379`	`SELECT * FROM check_estimated_rows('SELECT * FROM functional_dependencies WHERE a = 1 AND b = ''1''');`
`380`	`380`	`estimated \| actual`
`381`	`381`	`-----------+--------`
`@@ -408,7 +408,7 @@ TRUNCATE functional_dependencies;`
`408`	`408`	`DROP STATISTICS func_deps_stat;`
`409`	`409`	`INSERT INTO functional_dependencies (a, b, c, filler1)`
`410`	`410`	`SELECT mod(i,100), mod(i,50), mod(i,25), i FROM generate_series(1,5000) s(i);`
`411`		`-ANALYZE functional_dependencies;`
	`411`	`+VACUUM (ANALYZE) functional_dependencies;`
`412`	`412`	`SELECT * FROM check_estimated_rows('SELECT * FROM functional_dependencies WHERE a = 1 AND b = ''1''');`
`413`	`413`	`estimated \| actual`
`414`	`414`	`-----------+--------`
`@@ -741,7 +741,7 @@ SELECT * FROM check_estimated_rows('SELECT * FROM functional_dependencies WHERE`
`741`	`741`	`25 \| 50`
`742`	`742`	`(1 row)`
`743`	`743`
`744`		`-ANALYZE functional_dependencies;`
	`744`	`+VACUUM (ANALYZE) functional_dependencies;`
`745`	`745`	`SELECT * FROM check_estimated_rows('SELECT * FROM functional_dependencies WHERE a = 1 AND b = ''1'' AND c = 1');`
`746`	`746`	`estimated \| actual`
`747`	`747`	`-----------+--------`
`@@ -1398,7 +1398,7 @@ INSERT INTO mcv_lists_bool (a, b, c)`
`1398`	`1398`	`SELECT`
`1399`	`1399`	`(mod(i,2) = 0), (mod(i,4) = 0), (mod(i,8) = 0)`
`1400`	`1400`	`FROM generate_series(1,10000) s(i);`
`1401`		`-ANALYZE mcv_lists_bool;`
	`1401`	`+VACUUM (ANALYZE) mcv_lists_bool;`
`1402`	`1402`	`SELECT * FROM check_estimated_rows('SELECT * FROM mcv_lists_bool WHERE a AND b AND c');`
`1403`	`1403`	`estimated \| actual`
`1404`	`1404`	`-----------+--------`

`‎src/test/regress/sql/stats_ext.sql`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ INSERT INTO ndistinct (a, b, c, filler1)`
`191`	`191`	`cash_words(mod(i,33)::int::money)`
`192`	`192`	`FROM generate_series(1,5000) s(i);`
`193`	`193`
`194`		`-ANALYZE ndistinct;`
	`194`	`+VACUUM (ANALYZE) ndistinct;`
`195`	`195`
`196`	`196`	`SELECTs.stxkind,d.stxdndistinct`
`197`	`197`	`FROM pg_statistic_ext s, pg_statistic_ext_data d`
`@@ -245,7 +245,7 @@ CREATE INDEX fdeps_abc_idx ON functional_dependencies (a, b, c);`
`245`	`245`	`INSERT INTO functional_dependencies (a, b, c, filler1)`
`246`	`246`	`SELECT mod(i,23), mod(i,29), mod(i,31), iFROM generate_series(1,5000) s(i);`
`247`	`247`
`248`		`-ANALYZE functional_dependencies;`
	`248`	`+VACUUM (ANALYZE) functional_dependencies;`
`249`	`249`
`250`	`250`	`SELECTFROM check_estimated_rows('SELECT FROM functional_dependencies WHERE a = 1 AND b =''1''');`
`251`	`251`
`@@ -267,7 +267,7 @@ DROP STATISTICS func_deps_stat;`
`267`	`267`	`INSERT INTO functional_dependencies (a, b, c, filler1)`
`268`	`268`	`SELECT mod(i,100), mod(i,50), mod(i,25), iFROM generate_series(1,5000) s(i);`
`269`	`269`
`270`		`-ANALYZE functional_dependencies;`
	`270`	`+VACUUM (ANALYZE) functional_dependencies;`
`271`	`271`
`272`	`272`	`SELECTFROM check_estimated_rows('SELECT FROM functional_dependencies WHERE a = 1 AND b =''1''');`
`273`	`273`
`@@ -396,7 +396,7 @@ ALTER TABLE functional_dependencies ALTER COLUMN c TYPE numeric;`
`396`	`396`
`397`	`397`	`SELECTFROM check_estimated_rows('SELECT FROM functional_dependencies WHERE a = 1 AND b =''1'' AND c = 1');`
`398`	`398`
`399`		`-ANALYZE functional_dependencies;`
	`399`	`+VACUUM (ANALYZE) functional_dependencies;`
`400`	`400`
`401`	`401`	`SELECTFROM check_estimated_rows('SELECT FROM functional_dependencies WHERE a = 1 AND b =''1'' AND c = 1');`
`402`	`402`
`@@ -742,7 +742,7 @@ INSERT INTO mcv_lists_bool (a, b, c)`
`742`	`742`	`(mod(i,2)=0), (mod(i,4)=0), (mod(i,8)=0)`
`743`	`743`	`FROM generate_series(1,10000) s(i);`
`744`	`744`
`745`		`-ANALYZE mcv_lists_bool;`
	`745`	`+VACUUM (ANALYZE) mcv_lists_bool;`
`746`	`746`
`747`	`747`	`SELECTFROM check_estimated_rows('SELECT FROM mcv_lists_bool WHERE a AND b AND c');`
`748`	`748`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit24566b3

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/stats_ext.out`

`‎src/test/regress/sql/stats_ext.sql`

0 commit comments