Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2455ab4

Browse files
committed
Defend against leaks into RelationBuildPartitionDesc.
In normal builds, this isn't very important, because the leaks gointo fairly short-lived contexts, but under CLOBBER_CACHE_ALWAYS,this can result in leaking hundreds of megabytes into MessageContext,which probably explains recent failures on hyrax.This may or may not be the best long-term strategy for dealingwith this leak, but we can change it later if we come up withsomething better. For now, do this to make the buildfarm greenagain (hopefully). Commit898e5e3seems to have exacerbated this problem for reasons that are notquite clear, but I don't believe it's actually the cause.Discussion:http://postgr.es/m/CA+TgmoY3bRmGB6-DUnoVy5fJoreiBJ43rwMrQRCdPXuKt4Ykaw@mail.gmail.com
1 parentc6ff0b8 commit2455ab4

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

‎src/backend/partitioning/partdesc.c

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,17 @@ RelationBuildPartitionDesc(Relation rel)
6868
PartitionKeykey=RelationGetPartitionKey(rel);
6969
MemoryContextoldcxt;
7070
int*mapping;
71+
MemoryContextrbcontext=NULL;
72+
73+
/*
74+
* While building the partition descriptor, we create various temporary
75+
* data structures; in CLOBBER_CACHE_ALWAYS mode, at least, it's important
76+
* not to leak them, since this can get called a lot.
77+
*/
78+
rbcontext=AllocSetContextCreate(CurrentMemoryContext,
79+
"RelationBuildPartitionDesc",
80+
ALLOCSET_DEFAULT_SIZES);
81+
oldcxt=MemoryContextSwitchTo(rbcontext);
7182

7283
/*
7384
* Get partition oids from pg_inherits. This uses a single snapshot to
@@ -180,7 +191,7 @@ RelationBuildPartitionDesc(Relation rel)
180191
MemoryContextCopyAndSetIdentifier(rel->rd_pdcxt,
181192
RelationGetRelationName(rel));
182193

183-
oldcxt=MemoryContextSwitchTo(rel->rd_pdcxt);
194+
MemoryContextSwitchTo(rel->rd_pdcxt);
184195
partdesc= (PartitionDescData*)palloc0(sizeof(PartitionDescData));
185196
partdesc->nparts=nparts;
186197
/* oids and boundinfo are allocated below. */
@@ -189,7 +200,11 @@ RelationBuildPartitionDesc(Relation rel)
189200

190201
if (nparts==0)
191202
{
203+
/* We can exit early in this case. */
192204
rel->rd_partdesc=partdesc;
205+
206+
/* Blow away the temporary context. */
207+
MemoryContextDelete(rbcontext);
193208
return;
194209
}
195210

@@ -220,6 +235,9 @@ RelationBuildPartitionDesc(Relation rel)
220235
MemoryContextSwitchTo(oldcxt);
221236

222237
rel->rd_partdesc=partdesc;
238+
239+
/* Blow away the temporary context. */
240+
MemoryContextDelete(rbcontext);
223241
}
224242

225243
/*

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp