NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2423c84

committed

Make sure to run pg_isready on correct port

The current code can have pg_isready unexpectedly succeed if there is aserver running on the default port. To avoid this we delay running thetest until after a node has been created but before it starts, and thenuse that node's port, so we are fairly sure there is nothing running onthe port.Backpatch to all live branches.

1 parent3554d84 commit2423c84Copy full SHA for 2423c84

File tree

1 file changed

-2

lines changed

src/bin/scripts/t
- 080_pg_isready.pl

1 file changed

-2

lines changed

`‎src/bin/scripts/t/080_pg_isready.pl‎`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,11 @@`
`9`	`9`	`program_version_ok('pg_isready');`
`10`	`10`	`program_options_handling_ok('pg_isready');`
`11`	`11`
`12`		`-command_fails(['pg_isready'],'fails with no server running');`
`13`		`-`
`14`	`12`	`my$node = get_new_node('main');`
`15`	`13`	`$node->init;`
	`14`	`+`
	`15`	`+$node->command_fails(['pg_isready'],'fails with no server running');`
	`16`	`+`
`16`	`17`	`$node->start;`
`17`	`18`
`18`	`19`	`$node->command_ok(`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2423c84

File tree

1 file changed

1 file changed

`‎src/bin/scripts/t/080_pg_isready.pl‎`

0 commit comments