forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit23b09e1
committed
Adjust DatumGetBool macro, this time for sure.
Commit23a4157 attempted to fix the DatumGetBool macro to ignore bitsin a Datum that are to the left of the actual bool value. But it did thatby casting the Datum to bool; and on compilers that use C99 semantics forbool, that ends up being a whole-word test, not a 1-byte test. This seemsto be the true explanation for contrib/seg failing in VS2015. To fix, useGET_1_BYTE() explicitly. I think in the previous patch, I'd had some ideaof not having to commit to bool being exactly 1 byte wide, but regardlessof what the compiler's bool is, boolean columns and Datums are certainly1 byte wide.The previous fix was (eventually) back-patched into all active versions,so do likewise with this one.1 parentf050423 commit23b09e1
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
401 | | - | |
| 401 | + | |
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
| |||
0 commit comments
Comments
(0)