Commit239f74d

committed

psql forgot to close connection before re-issuing password prompt.

([BUGS] psql can crash the backend on login, 2000-09-03)

1 parentb5d609a commit239f74dCopy full SHA for 239f74d

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.35 2000/07/1718:24:32 petere Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.36 2000/09/1720:33:45 petere Exp $`
`7`	`7`	`*/`
`8`	`8`	`#include"postgres.h"`
`9`	`9`	`#include"command.h"`
`@@ -1237,6 +1237,7 @@ do_connect(const char new_dbname, const char new_user)`
`1237`	`1237`	`if (PQstatus(pset.db)==CONNECTION_BAD&&`
`1238`	`1238`	`strcmp(PQerrorMessage(pset.db),"fe_sendauth: no password supplied\n")==0)`
`1239`	`1239`	`{`
	`1240`	`+PQfinish(pset.db);`
`1240`	`1241`	`need_pass= true;`
`1241`	`1242`	`free(prompted_password);`
`1242`	`1243`	`prompted_password=NULL;`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/psql/startup.c,v 1.36 2000/09/06 19:54:48 petere Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/startup.c,v 1.37 2000/09/17 20:33:45 petere Exp $`
`7`	`7`	`*/`
`8`	`8`	`#include"postgres.h"`
`9`	`9`
`@@ -168,6 +168,7 @@ main(int argc, char *argv[])`
`168`	`168`	`if (PQstatus(pset.db)==CONNECTION_BAD&&`
`169`	`169`	`strcmp(PQerrorMessage(pset.db),"fe_sendauth: no password supplied\n")==0)`
`170`	`170`	`{`
	`171`	`+PQfinish(pset.db);`
`171`	`172`	`need_pass= true;`
`172`	`173`	`free(password);`
`173`	`174`	`password=NULL;`

Comments

(0)