NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2332808

committed

Remove dead assignment to local variable.

This should have been removed in commit7e30c18, which split the loopinto two. Only the first loop uses the 'from' variable; updating it inthe second loop is bogus. It was never read after the first loop, so thiswas harmless and surely optimized away by the compiler, but let's be tidy.Backpatch to all supported versions.Author: Ranier VilelaDiscussion:https://www.postgresql.org/message-id/CAEudQAoWq%2BAL3BnELHu7gms2GN07k-np6yLbukGaxJ1vY-zeiQ%40mail.gmail.com

1 parent166fcf4 commit2332808Copy full SHA for 2332808

File tree

1 file changed

-1

lines changed

src/backend/access/nbtree
- nbtxlog.c

1 file changed

-1

lines changed

`‎src/backend/access/nbtree/nbtxlog.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ _bt_restore_page(Page page, char *from, int len)`
`77`	`77`	`if (PageAddItem(page,items[i],itemsizes[i],nitems-i,`
`78`	`78`	`false, false)==InvalidOffsetNumber)`
`79`	`79`	`elog(PANIC,"_bt_restore_page: cannot add item to page");`
`80`		`-from+=itemsz;`
`81`	`80`	`}`
`82`	`81`	`}`
`83`	`82`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2332808

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtxlog.c`

0 commit comments