NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2308f18

committed

Count write times when extending relation files for shared buffers

Relation files extended multiple blocks at a time have been counting thenumber of blocks written, but forgot that to increment the write time inthis case, as write and relation extension are treated as two differentI/O operations in the shared stats: IOOP_EXTEND vs IOOP_WRITE. In thiscase IOOP_EXTEND was forgotten for normal (non-temporary) relations.Write times are tracked when track_io_timing is enabled, which is notthe case by default.Author: Nazir Bilal YavuzReviewed-by: Robert Haas, Melanie PlagemanDiscussion:https://postgr.es/m/CAN55FZ19Ss279mZuqGbuUNxka0iPbLgYuOQXqAKewrjNrp27VA@mail.gmail.comBackpatch-through: 16

1 parent4a427b8 commit2308f18Copy full SHA for 2308f18

File tree

1 file changed

-1

lines changed

src/backend/utils/activity
- pgstat_io.c

1 file changed

-1

lines changed

`‎src/backend/utils/activity/pgstat_io.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ pgstat_count_io_op_time(IOObject io_object, IOContext io_context, IOOp io_op,`
`119`	`119`	`INSTR_TIME_SET_CURRENT(io_time);`
`120`	`120`	`INSTR_TIME_SUBTRACT(io_time,start_time);`
`121`	`121`
`122`		`-if (io_op==IOOP_WRITE)`
	`122`	`+if (io_op==IOOP_WRITE\|\|io_op==IOOP_EXTEND)`
`123`	`123`	`{`
`124`	`124`	`pgstat_count_buffer_write_time(INSTR_TIME_GET_MICROSEC(io_time));`
`125`	`125`	`if (io_object==IOOBJECT_RELATION)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2308f18

File tree

1 file changed

1 file changed

`‎src/backend/utils/activity/pgstat_io.c‎`

0 commit comments