NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2271d00

committed

Fix "path" infrastructure bug affecting jsonb_set()

jsonb_set() and other clients of the setPathArray() utility functioncould get spurious results when an array integer subscript is providedthat is not within the range of int.To fix, ensure that the value returned by strtol() within setPathArray()is within the range of int; when it isn't, assume an invalid input inline with existing, similar cases. The path-orientated operators thatappeared in PostgreSQL 9.3 and 9.4 do not call setPathArray(), andalready independently take this precaution, so no change there.Peter Geoghegan

1 parentae58f14 commit2271d00Copy full SHA for 2271d00

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- jsonfuncs.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/jsonfuncs.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3814,11 +3814,14 @@ setPathArray(JsonbIterator *it, Datum path_elems, bool *path_nulls,`
`3814`	`3814`	`if (level<path_len&& !path_nulls[level])`
`3815`	`3815`	`{`
`3816`	`3816`	`char*c=VARDATA_ANY(path_elems[level]);`
	`3817`	`+longlindex;`
`3817`	`3818`
`3818`	`3819`	`errno=0;`
`3819`		`-idx= (int)strtol(c,&badp,10);`
`3820`		`-if (errno!=0\|\|badp==c)`
	`3820`	`+lindex=strtol(c,&badp,10);`
	`3821`	`+if (errno!=0\|\|badp==c\|\|lindex>INT_MAX\|\|lindex<INT_MIN)`
`3821`	`3822`	`idx=nelems;`
	`3823`	`+else`
	`3824`	`+idx=lindex;`
`3822`	`3825`	`}`
`3823`	`3826`	`else`
`3824`	`3827`	`idx=nelems;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2271d00

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/jsonfuncs.c`

0 commit comments