Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit223a946

Browse files
committed
Fix deadlock at startup, if max_prepared_transactions is too small.
When the startup process recovers transactions by scanning pg_twophasedirectory, it should clear MyLockedGxact after it's done processing eachtransaction. Like we do during normal operation, at PREPARE TRANSACTION.Otherwise, if the startup process exits due to an error, it will try toclear the locking_backend field of the last recovered transaction. That'susually harmless, but if the error happens in MarkAsPreparing, whileholding TwoPhaseStateLock, the shmem-exit hook will try to acquireTwoPhaseStateLock again, and deadlock with itself.This fixes bug #13128 reported by Grant McAlister. The bug was introducedby commitbb38fb0, so backpatch to all supported versions like thatcommit.
1 parent5feebfe commit223a946

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

‎src/backend/access/transam/twophase.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1998,6 +1998,12 @@ RecoverPreparedTransactions(void)
19981998
if (InHotStandby)
19991999
StandbyReleaseLockTree(xid,hdr->nsubxacts,subxids);
20002000

2001+
/*
2002+
* We're done with recovering this transaction. Clear MyLockedGxact,
2003+
* like we do in PrepareTransaction() during normal operation.
2004+
*/
2005+
PostPrepare_Twophase();
2006+
20012007
pfree(buf);
20022008
}
20032009
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp