NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit21c09e9

committed

Split heapam_xlog.h from heapam.h

The heapam XLog functions are used by other modules, not all of whichare interested in the rest of the heapam API. With this, we let themget just the XLog stuff in which they are interested and not pollutethem with unrelated includes.Also, since heapam.h no longer requires xlog.h, many files that doinclude heapam.h no longer get xlog.h automatically, including a fewheaders. This is useful because heapam.h is getting pulled in byexecnodes.h, which is in turn included by a lot of files.

1 parentfda0594 commit21c09e9Copy full SHA for 21c09e9

File tree

26 files changed

+287

-244

lines changed

src
- backend
  - access
    - gin
      - gininsert.c
    - heap
    - index
      - genam.c
    - nbtree
    - spgist
      - spginsert.c
    - transam
      - rmgr.c
  - commands
    - tablecmds.c
    - vacuumlazy.c
  - executor
    - nodeSubplan.c
  - foreign
    - foreign.c
  - nodes
    - print.c
  - optimizer
    - prep
      - prepunion.c
    - util
      - plancat.c
  - parser
    - parse_func.c
  - utils/adt
    - domains.c
    - regproc.c
- include
  - access
  - commands
    - explain.h
    - prepare.h

26 files changed

+287

-244

lines changed

`‎src/backend/access/gin/gininsert.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`#include"postgres.h"`
`16`	`16`
`17`	`17`	`#include"access/gin_private.h"`
	`18`	`+#include"access/heapam_xlog.h"`
`18`	`19`	`#include"catalog/index.h"`
`19`	`20`	`#include"miscadmin.h"`
`20`	`21`	`#include"storage/bufmgr.h"`

`‎src/backend/access/heap/heapam.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@`
`41`	`41`	`#include"postgres.h"`
`42`	`42`
`43`	`43`	`#include"access/heapam.h"`
	`44`	`+#include"access/heapam_xlog.h"`
`44`	`45`	`#include"access/hio.h"`
`45`	`46`	`#include"access/multixact.h"`
`46`	`47`	`#include"access/relscan.h"`

`‎src/backend/access/heap/pruneheap.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`#include"postgres.h"`
`16`	`16`
`17`	`17`	`#include"access/heapam.h"`
	`18`	`+#include"access/heapam_xlog.h"`
`18`	`19`	`#include"access/transam.h"`
`19`	`20`	`#include"miscadmin.h"`
`20`	`21`	`#include"pgstat.h"`

`‎src/backend/access/heap/rewriteheap.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,7 @@`
`103`	`103`	`#include"postgres.h"`
`104`	`104`
`105`	`105`	`#include"access/heapam.h"`
	`106`	`+#include"access/heapam_xlog.h"`
`106`	`107`	`#include"access/rewriteheap.h"`
`107`	`108`	`#include"access/transam.h"`
`108`	`109`	`#include"access/tuptoaster.h"`

`‎src/backend/access/heap/visibilitymap.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@`
`82`	`82`	`*/`
`83`	`83`	`#include"postgres.h"`
`84`	`84`
`85`		`-#include"access/heapam.h"`
	`85`	`+#include"access/heapam_xlog.h"`
`86`	`86`	`#include"access/visibilitymap.h"`
`87`	`87`	`#include"miscadmin.h"`
`88`	`88`	`#include"storage/bufmgr.h"`

`‎src/backend/access/index/genam.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`#include"access/relscan.h"`
`23`	`23`	`#include"access/transam.h"`
`24`	`24`	`#include"catalog/index.h"`
	`25`	`+#include"lib/stringinfo.h"`
`25`	`26`	`#include"miscadmin.h"`
`26`	`27`	`#include"storage/bufmgr.h"`
`27`	`28`	`#include"utils/builtins.h"`

`‎src/backend/access/nbtree/nbtree.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`*/`
`19`	`19`	`#include"postgres.h"`
`20`	`20`
	`21`	`+#include"access/heapam_xlog.h"`
`21`	`22`	`#include"access/nbtree.h"`
`22`	`23`	`#include"access/relscan.h"`
`23`	`24`	`#include"catalog/index.h"`

`‎src/backend/access/nbtree/nbtsort.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@`
`66`	`66`
`67`	`67`	`#include"postgres.h"`
`68`	`68`
	`69`	`+#include"access/heapam_xlog.h"`
`69`	`70`	`#include"access/nbtree.h"`
`70`	`71`	`#include"miscadmin.h"`
`71`	`72`	`#include"storage/smgr.h"`

`‎src/backend/access/nbtree/nbtxlog.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`	`*/`
`15`	`15`	`#include"postgres.h"`
`16`	`16`
	`17`	`+#include"access/heapam_xlog.h"`
`17`	`18`	`#include"access/nbtree.h"`
`18`	`19`	`#include"access/transam.h"`
`19`	`20`	`#include"storage/procarray.h"`

`‎src/backend/access/spgist/spginsert.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`#include"postgres.h"`
`18`	`18`
`19`	`19`	`#include"access/genam.h"`
	`20`	`+#include"access/heapam_xlog.h"`
`20`	`21`	`#include"access/spgist_private.h"`
`21`	`22`	`#include"catalog/index.h"`
`22`	`23`	`#include"miscadmin.h"`

`‎src/backend/access/transam/rmgr.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`#include"access/gin.h"`
`12`	`12`	`#include"access/gist_private.h"`
`13`	`13`	`#include"access/hash.h"`
`14`		`-#include"access/heapam.h"`
	`14`	`+#include"access/heapam_xlog.h"`
`15`	`15`	`#include"access/multixact.h"`
`16`	`16`	`#include"access/nbtree.h"`
`17`	`17`	`#include"access/spgist.h"`

`‎src/backend/commands/tablecmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`#include"postgres.h"`
`16`	`16`
`17`	`17`	`#include"access/genam.h"`
`18`		`-#include"access/heapam.h"`
	`18`	`+#include"access/heapam_xlog.h"`
`19`	`19`	`#include"access/reloptions.h"`
`20`	`20`	`#include"access/relscan.h"`
`21`	`21`	`#include"access/sysattr.h"`

`‎src/backend/commands/vacuumlazy.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@`
`39`	`39`
`40`	`40`	`#include"access/genam.h"`
`41`	`41`	`#include"access/heapam.h"`
	`42`	`+#include"access/heapam_xlog.h"`
`42`	`43`	`#include"access/transam.h"`
`43`	`44`	`#include"access/visibilitymap.h"`
`44`	`45`	`#include"catalog/storage.h"`

`‎src/backend/executor/nodeSubplan.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`*/`
`19`	`19`	`#include"postgres.h"`
`20`	`20`
	`21`	`+#include<limits.h>`
`21`	`22`	`#include<math.h>`
`22`	`23`
`23`	`24`	`#include"executor/executor.h"`

`‎src/backend/foreign/foreign.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`#include"catalog/pg_user_mapping.h"`
`20`	`20`	`#include"foreign/fdwapi.h"`
`21`	`21`	`#include"foreign/foreign.h"`
	`22`	`+#include"lib/stringinfo.h"`
`22`	`23`	`#include"miscadmin.h"`
`23`	`24`	`#include"utils/builtins.h"`
`24`	`25`	`#include"utils/syscache.h"`

`‎src/backend/nodes/print.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`#include"postgres.h"`
`21`	`21`
`22`	`22`	`#include"access/printtup.h"`
	`23`	`+#include"lib/stringinfo.h"`
`23`	`24`	`#include"nodes/print.h"`
`24`	`25`	`#include"optimizer/clauses.h"`
`25`	`26`	`#include"parser/parsetree.h"`

`‎src/backend/optimizer/prep/prepunion.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`	`*/`
`29`	`29`	`#include"postgres.h"`
`30`	`30`
	`31`	`+#include<limits.h>`
`31`	`32`
`32`	`33`	`#include"access/heapam.h"`
`33`	`34`	`#include"access/sysattr.h"`

`‎src/backend/optimizer/util/plancat.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@`
`21`	`21`	`#include"access/heapam.h"`
`22`	`22`	`#include"access/sysattr.h"`
`23`	`23`	`#include"access/transam.h"`
	`24`	`+#include"access/xlog.h"`
`24`	`25`	`#include"catalog/catalog.h"`
`25`	`26`	`#include"catalog/heap.h"`
`26`	`27`	`#include"miscadmin.h"`

`‎src/backend/parser/parse_func.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`#include"catalog/pg_proc.h"`
`18`	`18`	`#include"catalog/pg_type.h"`
`19`	`19`	`#include"funcapi.h"`
	`20`	`+#include"lib/stringinfo.h"`
`20`	`21`	`#include"nodes/makefuncs.h"`
`21`	`22`	`#include"nodes/nodeFuncs.h"`
`22`	`23`	`#include"parser/parse_agg.h"`

`‎src/backend/utils/adt/domains.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@`
`33`	`33`
`34`	`34`	`#include"commands/typecmds.h"`
`35`	`35`	`#include"executor/executor.h"`
	`36`	`+#include"lib/stringinfo.h"`
`36`	`37`	`#include"utils/builtins.h"`
`37`	`38`	`#include"utils/lsyscache.h"`
`38`	`39`

`‎src/backend/utils/adt/regproc.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@`
`31`	`31`	`#include"catalog/pg_ts_config.h"`
`32`	`32`	`#include"catalog/pg_ts_dict.h"`
`33`	`33`	`#include"catalog/pg_type.h"`
	`34`	`+#include"lib/stringinfo.h"`
`34`	`35`	`#include"miscadmin.h"`
`35`	`36`	`#include"parser/parse_type.h"`
`36`	`37`	`#include"utils/builtins.h"`

`‎src/include/access/heapam.h`

Lines changed: 0 additions & 22 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`
`17`	`17`	`#include"access/sdir.h"`
`18`	`18`	`#include"access/skey.h"`
`19`		`-#include"access/xlog.h"`
`20`	`19`	`#include"nodes/primnodes.h"`
`21`	`20`	`#include"storage/lock.h"`
`22`	`21`	`#include"utils/relcache.h"`
`@@ -125,27 +124,6 @@ extern void heap_restrpos(HeapScanDesc scan);`
`125`	`124`
`126`	`125`	`externvoidheap_sync(Relationrelation);`
`127`	`126`
`128`		`-externvoidheap_redo(XLogRecPtrlsn,XLogRecord*rptr);`
`129`		`-externvoidheap_desc(StringInfobuf,uint8xl_info,char*rec);`
`130`		`-externvoidheap2_redo(XLogRecPtrlsn,XLogRecord*rptr);`
`131`		`-externvoidheap2_desc(StringInfobuf,uint8xl_info,char*rec);`
`132`		`-`
`133`		`-externXLogRecPtrlog_heap_cleanup_info(RelFileNodernode,`
`134`		`-TransactionIdlatestRemovedXid);`
`135`		`-externXLogRecPtrlog_heap_clean(Relationreln,Bufferbuffer,`
`136`		`-OffsetNumber*redirected,intnredirected,`
`137`		`-OffsetNumber*nowdead,intndead,`
`138`		`-OffsetNumber*nowunused,intnunused,`
`139`		`-TransactionIdlatestRemovedXid);`
`140`		`-externXLogRecPtrlog_heap_freeze(Relationreln,Bufferbuffer,`
`141`		`-TransactionIdcutoff_xid,`
`142`		`-OffsetNumber*offsets,intoffcnt);`
`143`		`-externXLogRecPtrlog_heap_visible(RelFileNodernode,BlockNumberblock,`
`144`		`-Buffervm_buffer,TransactionIdcutoff_xid);`
`145`		`-externXLogRecPtrlog_newpage(RelFileNode*rnode,ForkNumberforkNum,`
`146`		`-BlockNumberblk,Pagepage);`
`147`		`-externXLogRecPtrlog_newpage_buffer(Bufferbuffer);`
`148`		`-`
`149`	`127`	`/* in heap/pruneheap.c */`
`150`	`128`	`externvoidheap_page_prune_opt(Relationrelation,Bufferbuffer,`
`151`	`129`	`TransactionIdOldestXmin);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit21c09e9

File tree

26 files changed

26 files changed

`‎src/backend/access/gin/gininsert.c`

`‎src/backend/access/heap/heapam.c`

`‎src/backend/access/heap/pruneheap.c`

`‎src/backend/access/heap/rewriteheap.c`

`‎src/backend/access/heap/visibilitymap.c`

`‎src/backend/access/index/genam.c`

`‎src/backend/access/nbtree/nbtree.c`

`‎src/backend/access/nbtree/nbtsort.c`

`‎src/backend/access/nbtree/nbtxlog.c`

`‎src/backend/access/spgist/spginsert.c`

`‎src/backend/access/transam/rmgr.c`

`‎src/backend/commands/tablecmds.c`

`‎src/backend/commands/vacuumlazy.c`

`‎src/backend/executor/nodeSubplan.c`

`‎src/backend/foreign/foreign.c`

`‎src/backend/nodes/print.c`

`‎src/backend/optimizer/prep/prepunion.c`

`‎src/backend/optimizer/util/plancat.c`

`‎src/backend/parser/parse_func.c`

`‎src/backend/utils/adt/domains.c`

`‎src/backend/utils/adt/regproc.c`

`‎src/include/access/heapam.h`

0 commit comments