NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit21b3aa9

committed

Remove newly added useless assertion check

Coverity complained that my commit80ba4bb added a dubious codingfor a consistency check that there isn't more than one row for a certaintgrelid/tgparentid combination. But we don't check for that explicitlyanywhere else, and if we were to do it, it should be a fullshouldn't-happen elog not just an assert. It doesn't seem that this isvery important anyway, so remove it.Discussion:https://postgr.es/m/1337562.1627224583@sss.pgh.pa.us

1 parentf68b609 commit21b3aa9Copy full SHA for 21b3aa9

File tree

1 file changed

-3

lines changed

src/backend/commands
- trigger.c

1 file changed

-3

lines changed

`‎src/backend/commands/trigger.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1615,7 +1615,6 @@ renametrig_partition(Relation tgrel, Oid partitionId, Oid parentTriggerOid,`
`1615`	`1615`	`SysScanDesctgscan;`
`1616`	`1616`	`ScanKeyDatakey;`
`1617`	`1617`	`HeapTupletuple;`
`1618`		`-intfoundPG_USED_FOR_ASSERTS_ONLY=0;`
`1619`	`1618`
`1620`	`1619`	`/*`
`1621`	`1620`	`* Given a relation and the OID of a trigger on parent relation, find the`
`@@ -1636,8 +1635,6 @@ renametrig_partition(Relation tgrel, Oid partitionId, Oid parentTriggerOid,`
`1636`	`1635`	`if (tgform->tgparentid!=parentTriggerOid)`
`1637`	`1636`	`continue;/* not our trigger */`
`1638`	`1637`
`1639`		`-Assert(found++ <=0);`
`1640`		`-`
`1641`	`1638`	`partitionRel=table_open(partitionId,NoLock);`
`1642`	`1639`
`1643`	`1640`	`/* Rename the trigger on this partition */`
`@@ -1658,6 +1655,9 @@ renametrig_partition(Relation tgrel, Oid partitionId, Oid parentTriggerOid,`
`1658`	`1655`	`}`
`1659`	`1656`	`}`
`1660`	`1657`	`table_close(partitionRel,NoLock);`
	`1658`	`+`
	`1659`	`+/* There should be at most one matching tuple */`
	`1660`	`+break;`
`1661`	`1661`	`}`
`1662`	`1662`	`systable_endscan(tgscan);`
`1663`	`1663`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit21b3aa9

File tree

1 file changed

1 file changed

`‎src/backend/commands/trigger.c`

0 commit comments