forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit218527d
committed
Don't bother checking the result of SPI_connect[_ext] anymore.
SPI_connect/SPI_connect_ext have not returned any value other thanSPI_OK_CONNECT since commit1833f1a in v10; any errors are thrownvia ereport. (The most likely failure is out-of-memory, which hasalways been thrown that way, so callers had better be prepared forsuch errors.) This makes it somewhat pointless to check thesefunctions' result, and some callers within our code haven't beenbothering; indeed, the only usage example within spi.sgml doesn'tbother. So it's likely that the omission has propagated intoextensions too.Hence, let's standardize on not checking, and document the returnvalue as historical, while not actually changing these functions'behavior. (The original proposal was to change their return typeto "void", but that would needlessly break extensions that areconforming to the old practice.) This saves a small amount ofboilerplate code in a lot of places.Stepan NeretinDiscussion:https://postgr.es/m/CAMaYL5Z9Uk8cD9qGz9QaZ2UBJFOu7jFx5Mwbznz-1tBbPDQZow@mail.gmail.com1 parentcdb6b0f commit218527d
File tree
16 files changed
+44
-88
lines changed- contrib
- dblink
- spi
- tablefunc
- xml2
- doc/src/sgml
- src
- backend
- commands
- utils/adt
- pl
- plperl
- plpgsql/src
- plpython
- tcl
- test
- modules
- plsample
- test_predtest
- regress
16 files changed
+44
-88
lines changedLines changed: 1 addition & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2377 | 2377 |
| |
2378 | 2378 |
| |
2379 | 2379 |
| |
2380 |
| - | |
2381 |
| - | |
2382 |
| - | |
| 2380 | + | |
2383 | 2381 |
| |
2384 | 2382 |
| |
2385 | 2383 |
| |
|
Lines changed: 2 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
108 | 108 |
| |
109 | 109 |
| |
110 | 110 |
| |
111 |
| - | |
112 |
| - | |
113 |
| - | |
| 111 | + | |
114 | 112 |
| |
115 | 113 |
| |
116 | 114 |
| |
| |||
328 | 326 |
| |
329 | 327 |
| |
330 | 328 |
| |
331 |
| - | |
332 |
| - | |
333 |
| - | |
| 329 | + | |
334 | 330 |
| |
335 | 331 |
| |
336 | 332 |
| |
|
Lines changed: 4 additions & 14 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
385 | 385 |
| |
386 | 386 |
| |
387 | 387 |
| |
388 |
| - | |
389 |
| - | |
390 |
| - | |
| 388 | + | |
391 | 389 |
| |
392 | 390 |
| |
393 | 391 |
| |
| |||
724 | 722 |
| |
725 | 723 |
| |
726 | 724 |
| |
727 |
| - | |
728 |
| - | |
729 |
| - | |
| 725 | + | |
730 | 726 |
| |
731 | 727 |
| |
732 | 728 |
| |
| |||
806 | 802 |
| |
807 | 803 |
| |
808 | 804 |
| |
809 |
| - | |
810 |
| - | |
811 |
| - | |
| 805 | + | |
812 | 806 |
| |
813 | 807 |
| |
814 | 808 |
| |
| |||
1151 | 1145 |
| |
1152 | 1146 |
| |
1153 | 1147 |
| |
1154 |
| - | |
1155 | 1148 |
| |
1156 |
| - | |
1157 | 1149 |
| |
1158 | 1150 |
| |
1159 | 1151 |
| |
1160 |
| - | |
1161 |
| - | |
1162 |
| - | |
| 1152 | + | |
1163 | 1153 |
| |
1164 | 1154 |
| |
1165 | 1155 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
560 | 560 |
| |
561 | 561 |
| |
562 | 562 |
| |
563 |
| - | |
564 |
| - | |
| 563 | + | |
565 | 564 |
| |
566 | 565 |
| |
567 | 566 |
| |
|
Lines changed: 9 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
126 | 126 |
| |
127 | 127 |
| |
128 | 128 |
| |
129 |
| - | |
130 |
| - | |
131 |
| - | |
132 |
| - | |
133 |
| - | |
134 |
| - | |
135 |
| - | |
136 |
| - | |
137 |
| - | |
138 | 129 |
| |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
139 | 139 |
| |
140 | 140 |
| |
141 | 141 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
915 | 915 |
| |
916 | 916 |
| |
917 | 917 |
| |
918 |
| - | |
919 |
| - | |
| 918 | + | |
920 | 919 |
| |
921 | 920 |
| |
922 | 921 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
639 | 639 |
| |
640 | 640 |
| |
641 | 641 |
| |
642 |
| - | |
643 |
| - | |
| 642 | + | |
644 | 643 |
| |
645 | 644 |
| |
646 | 645 |
| |
|
Lines changed: 8 additions & 16 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
340 | 340 |
| |
341 | 341 |
| |
342 | 342 |
| |
343 |
| - | |
344 |
| - | |
| 343 | + | |
345 | 344 |
| |
346 | 345 |
| |
347 | 346 |
| |
| |||
469 | 468 |
| |
470 | 469 |
| |
471 | 470 |
| |
472 |
| - | |
473 |
| - | |
| 471 | + | |
474 | 472 |
| |
475 | 473 |
| |
476 | 474 |
| |
| |||
656 | 654 |
| |
657 | 655 |
| |
658 | 656 |
| |
659 |
| - | |
660 |
| - | |
| 657 | + | |
661 | 658 |
| |
662 | 659 |
| |
663 | 660 |
| |
| |||
766 | 763 |
| |
767 | 764 |
| |
768 | 765 |
| |
769 |
| - | |
770 |
| - | |
| 766 | + | |
771 | 767 |
| |
772 | 768 |
| |
773 | 769 |
| |
| |||
875 | 871 |
| |
876 | 872 |
| |
877 | 873 |
| |
878 |
| - | |
879 |
| - | |
| 874 | + | |
880 | 875 |
| |
881 | 876 |
| |
882 | 877 |
| |
| |||
1051 | 1046 |
| |
1052 | 1047 |
| |
1053 | 1048 |
| |
1054 |
| - | |
1055 |
| - | |
| 1049 | + | |
1056 | 1050 |
| |
1057 | 1051 |
| |
1058 | 1052 |
| |
| |||
1547 | 1541 |
| |
1548 | 1542 |
| |
1549 | 1543 |
| |
1550 |
| - | |
1551 |
| - | |
| 1544 | + | |
1552 | 1545 |
| |
1553 | 1546 |
| |
1554 | 1547 |
| |
| |||
1787 | 1780 |
| |
1788 | 1781 |
| |
1789 | 1782 |
| |
1790 |
| - | |
1791 |
| - | |
| 1783 | + | |
1792 | 1784 |
| |
1793 | 1785 |
| |
1794 | 1786 |
| |
|
Lines changed: 2 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
589 | 589 |
| |
590 | 590 |
| |
591 | 591 |
| |
592 |
| - | |
593 |
| - | |
| 592 | + | |
594 | 593 |
| |
595 | 594 |
| |
596 | 595 |
| |
| |||
782 | 781 |
| |
783 | 782 |
| |
784 | 783 |
| |
785 |
| - | |
786 |
| - | |
| 784 | + | |
787 | 785 |
| |
788 | 786 |
| |
789 | 787 |
| |
|
Lines changed: 4 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1947 | 1947 |
| |
1948 | 1948 |
| |
1949 | 1949 |
| |
1950 |
| - | |
1951 |
| - | |
| 1950 | + | |
1952 | 1951 |
| |
1953 | 1952 |
| |
1954 | 1953 |
| |
| |||
2412 | 2411 |
| |
2413 | 2412 |
| |
2414 | 2413 |
| |
2415 |
| - | |
2416 |
| - | |
| 2414 | + | |
2417 | 2415 |
| |
2418 | 2416 |
| |
2419 | 2417 |
| |
| |||
2530 | 2528 |
| |
2531 | 2529 |
| |
2532 | 2530 |
| |
2533 |
| - | |
2534 |
| - | |
| 2531 | + | |
2535 | 2532 |
| |
2536 | 2533 |
| |
2537 | 2534 |
| |
| |||
2638 | 2635 |
| |
2639 | 2636 |
| |
2640 | 2637 |
| |
2641 |
| - | |
2642 |
| - | |
| 2638 | + | |
2643 | 2639 |
| |
2644 | 2640 |
| |
2645 | 2641 |
| |
|
Lines changed: 3 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
235 | 235 |
| |
236 | 236 |
| |
237 | 237 |
| |
238 |
| - | |
239 |
| - | |
| 238 | + | |
240 | 239 |
| |
241 | 240 |
| |
242 | 241 |
| |
| |||
326 | 325 |
| |
327 | 326 |
| |
328 | 327 |
| |
329 |
| - | |
330 |
| - | |
| 328 | + | |
331 | 329 |
| |
332 | 330 |
| |
333 | 331 |
| |
| |||
510 | 508 |
| |
511 | 509 |
| |
512 | 510 |
| |
513 |
| - | |
514 |
| - | |
| 511 | + | |
515 | 512 |
| |
516 | 513 |
| |
517 | 514 |
| |
|
Lines changed: 2 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
202 | 202 |
| |
203 | 203 |
| |
204 | 204 |
| |
205 |
| - | |
206 |
| - | |
| 205 | + | |
207 | 206 |
| |
208 | 207 |
| |
209 | 208 |
| |
| |||
272 | 271 |
| |
273 | 272 |
| |
274 | 273 |
| |
275 |
| - | |
276 |
| - | |
| 274 | + | |
277 | 275 |
| |
278 | 276 |
| |
279 | 277 |
| |
|
Lines changed: 3 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
808 | 808 |
| |
809 | 809 |
| |
810 | 810 |
| |
811 |
| - | |
812 |
| - | |
| 811 | + | |
813 | 812 |
| |
814 | 813 |
| |
815 | 814 |
| |
| |||
1072 | 1071 |
| |
1073 | 1072 |
| |
1074 | 1073 |
| |
1075 |
| - | |
1076 |
| - | |
| 1074 | + | |
1077 | 1075 |
| |
1078 | 1076 |
| |
1079 | 1077 |
| |
| |||
1321 | 1319 |
| |
1322 | 1320 |
| |
1323 | 1321 |
| |
1324 |
| - | |
1325 |
| - | |
| 1322 | + | |
1326 | 1323 |
| |
1327 | 1324 |
| |
1328 | 1325 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
220 | 220 |
| |
221 | 221 |
| |
222 | 222 |
| |
223 |
| - | |
224 |
| - | |
| 223 | + | |
225 | 224 |
| |
226 | 225 |
| |
227 | 226 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
54 | 54 |
| |
55 | 55 |
| |
56 | 56 |
| |
57 |
| - | |
58 |
| - | |
| 57 | + | |
59 | 58 |
| |
60 | 59 |
| |
61 | 60 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
379 | 379 |
| |
380 | 380 |
| |
381 | 381 |
| |
382 |
| - | |
383 |
| - | |
| 382 | + | |
384 | 383 |
| |
385 | 384 |
| |
386 | 385 |
| |
|
0 commit comments
Comments
(0)